-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed to serialize CDATASection nodes #2
Comments
When I try to run this code in Node.js, I get a syntax error about import not being supported. Can you edit it to be valid JavaScript code that we can run and reproduce the issue? You also deleted other important parts of the issue template, like version numbers. We'll reopen when you've done so and confirmed that the problem still occurs. |
@domenic There's no Issue template in this repository... In my opinion, there's no relationship with ECMAScript syntax or Runtime environment about this bug. I located the code which throw this error with the Call stack's help, I think we should follow the DOM specification~ |
Sorry about that, I thought we were in the jsdom repository. Still, it's good practice to produce code that the people you're reporting the issue to can actually run. |
@domenic How about my PR? Is there anything need to change? |
So... the DOM Parsing and Serialization specification which defines XMLSerializer does not include instructions for serializing a CDATASection node, and the main DOM specification does not supersede it by itself. While we usually follow the specifications closely, current browsers seem to serialize CDATASection nodes without issue so making an exception here may be appropriate. @domenic, do you know if this is a case where the DOM Parsing and Serialization specification has not kept up with the main DOM specification? |
I think this is indeed a part where DOM P&S has not kept up. @Zirro has filed w3c/DOM-Parsing#38 for us. @TechQuery, can you add a link to w3c/DOM-Parsing#38 in your pull request? |
Actual
Expected
https://codepen.io/tech_query/pen/KrmxmQ
Environment
Windows 10.0.17134.407
The text was updated successfully, but these errors were encountered: