Skip to content

Refactor to TypeScript #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
blakeembrey wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor to TypeScript #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .eslintignore
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions .eslintrc.yml
View file
Open in desktop

This file was deleted.

234 changes: 16 additions & 218 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,230 +1,28 @@
name: ci
name: CI

on:
- pull_request
- push
- pull_request
- push

permissions:
contents: read

jobs:
test:
permissions:
checks: write # for coverallsapp/github-action to create new checks
contents: read # for actions/checkout to fetch code
name: Node.js ${{ matrix.node-version }}
runs-on: ubuntu-latest
strategy:
matrix:
name:
- Node.js 0.8
- Node.js 0.10
- Node.js 0.12
- io.js 1.x
- io.js 2.x
- io.js 3.x
- Node.js 4.x
- Node.js 5.x
- Node.js 6.x
- Node.js 7.x
- Node.js 8.x
- Node.js 9.x
- Node.js 10.x
- Node.js 11.x
- Node.js 12.x
- Node.js 13.x
- Node.js 14.x
- Node.js 15.x
- Node.js 16.x
- Node.js 17.x
- Node.js 18.x
- Node.js 19.x
- Node.js 20.x
- Node.js 21.x
- Node.js 22.x

include:

- name: Node.js 0.8
node-version: "0.8"
npm-i: [email protected]
npm-rm: nyc

- name: Node.js 0.10
node-version: "0.10"
npm-i: [email protected] [email protected]

- name: Node.js 0.12
node-version: "0.12"
npm-i: [email protected] [email protected]

- name: io.js 1.x
node-version: "1.8"
npm-i: [email protected] [email protected]

- name: io.js 2.x
node-version: "2.5"
npm-i: [email protected] [email protected]

- name: io.js 3.x
node-version: "3.3"
npm-i: [email protected] [email protected]

- name: Node.js 4.x
node-version: "4.9"
npm-i: [email protected] [email protected]

- name: Node.js 5.x
node-version: "5.12"
npm-i: [email protected] [email protected]

- name: Node.js 6.x
node-version: "6.17"
npm-i: [email protected] [email protected]

- name: Node.js 7.x
node-version: "7.10"
npm-i: [email protected] [email protected]

- name: Node.js 8.x
node-version: "8.17"
npm-i: [email protected] [email protected]

- name: Node.js 9.x
node-version: "9.11"
npm-i: [email protected] [email protected]

- name: Node.js 10.x
node-version: "10.24"
npm-i: [email protected]

- name: Node.js 11.x
node-version: "11.15"
npm-i: [email protected]

- name: Node.js 12.x
node-version: "12.22"
npm-i: [email protected]

- name: Node.js 13.x
node-version: "13.14"
npm-i: [email protected]

- name: Node.js 14.x
node-version: "14.21"

- name: Node.js 15.x
node-version: "15.14"

- name: Node.js 16.x
node-version: "16.20"

- name: Node.js 17.x
node-version: "17.9"

- name: Node.js 18.x
node-version: "18.18"

- name: Node.js 19.x
node-version: "19.9"

- name: Node.js 20.x
node-version: "20.9"

- name: Node.js 21.x
node-version: "21.7"

- name: Node.js 22.x
node-version: "22.0"

steps:
- uses: actions/[email protected]

- name: Install Node.js ${{ matrix.node-version }}
shell: bash -eo pipefail -l {0}
run: |
nvm install --default ${{ matrix.node-version }}
if [[ "${{ matrix.node-version }}" == 0.* && "$(cut -d. -f2 <<< "${{ matrix.node-version }}")" -lt 10 ]]; then
nvm install --alias=npm 0.10
nvm use ${{ matrix.node-version }}
if [[ "$(npm -v)" == 1.1.* ]]; then
nvm exec npm npm install -g [email protected]
ln -fs "$(which npm)" "$(dirname "$(nvm which npm)")/npm"
else
sed -i '1s;^.*$;'"$(printf '#!%q' "$(nvm which npm)")"';' "$(readlink -f "$(which npm)")"
fi
npm config set strict-ssl false
fi
dirname "$(nvm which ${{ matrix.node-version }})" >> "$GITHUB_PATH"

- name: Configure npm
run: |
if [[ "$(npm config get package-lock)" == "true" ]]; then
npm config set package-lock false
else
npm config set shrinkwrap false
fi

- name: Remove npm module(s) ${{ matrix.npm-rm }}
run: npm rm --silent --save-dev ${{ matrix.npm-rm }}
if: matrix.npm-rm != ''

- name: Install npm module(s) ${{ matrix.npm-i }}
run: npm install --save-dev ${{ matrix.npm-i }}
if: matrix.npm-i != ''

- name: Setup Node.js version-specific dependencies
shell: bash
run: |
# eslint for linting
# - remove on Node.js < 8
if [[ "$(cut -d. -f1 <<< "${{ matrix.node-version }}")" -lt 8 ]]; then
node -pe 'Object.keys(require("./package").devDependencies).join("\n")' | \
grep -E '^eslint(-|$)' | \
sort -r | \
xargs -n1 npm rm --silent --save-dev
fi

- name: Install Node.js dependencies
run: npm install

- name: List environment
id: list_env
shell: bash
run: |
echo "node@$(node -v)"
echo "npm@$(npm -v)"
npm -s ls ||:
(npm -s ls --depth=0 ||:) | awk -F'[ @]' 'NR>1 && $2 { print "::set-output name=" $2 "::" $3 }'

- name: Run tests
shell: bash
run: |
if npm -ps ls nyc | grep -q nyc; then
npm run test-ci
else
npm test
fi

- name: Lint code
if: steps.list_env.outputs.eslint != ''
run: npm run lint

- name: Collect code coverage
uses: coverallsapp/github-action@master
if: steps.list_env.outputs.nyc != ''
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
flag-name: run-${{ matrix.test_number }}
parallel: true

coverage:
permissions:
checks: write # for coverallsapp/github-action to create new checks
needs: test
runs-on: ubuntu-latest
node-version:
- "20"
- "*"
steps:
- name: Upload code coverage
uses: coverallsapp/github-action@master
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
parallel-finished: true
- uses: actions/checkout@v5
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: npm install
- run: npm test
- uses: codecov/codecov-action@v5
with:
name: Node.js ${{ matrix.node-version }}
2 changes: 2 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,5 @@
node_modules
coverage
package-lock.json
dist/
*.tsbuildinfo
59 changes: 24 additions & 35 deletions HISTORY.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,56 +1,45 @@
1.2.1 / 2019-05-10
==================
# 1.2.1 / 2019-05-10

* Improve error when `str` is not a string
- Improve error when `str` is not a string

1.2.0 / 2016-06-01
==================
# 1.2.0 / 2016-06-01

* Add `combine` option to combine overlapping ranges
- Add `combine` option to combine overlapping ranges

1.1.0 / 2016-05-13
==================
# 1.1.0 / 2016-05-13

* Fix incorrectly returning -1 when there is at least one valid range
* perf: remove internal function
- Fix incorrectly returning -1 when there is at least one valid range
- perf: remove internal function

1.0.3 / 2015-10-29
==================
# 1.0.3 / 2015-10-29

* perf: enable strict mode
- perf: enable strict mode

1.0.2 / 2014-09-08
==================
# 1.0.2 / 2014-09-08

* Support Node.js 0.6
- Support Node.js 0.6

1.0.1 / 2014-09-07
==================
# 1.0.1 / 2014-09-07

* Move repository to jshttp
- Move repository to jshttp

1.0.0 / 2013-12-11
==================
# 1.0.0 / 2013-12-11

* Add repository to package.json
* Add MIT license
- Add repository to package.json
- Add MIT license

0.0.4 / 2012-06-17
==================
# 0.0.4 / 2012-06-17

* Change ret -1 for unsatisfiable and -2 when invalid
- Change ret -1 for unsatisfiable and -2 when invalid

0.0.3 / 2012-06-17
==================
# 0.0.3 / 2012-06-17

* Fix last-byte-pos default to len - 1
- Fix last-byte-pos default to len - 1

0.0.2 / 2012-06-14
==================
# 0.0.2 / 2012-06-14

* Add `.type`
- Add `.type`

0.0.1 / 2012-06-11
==================
# 0.0.1 / 2012-06-11

* Initial release
- Initial release
18 changes: 7 additions & 11 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $ npm install range-parser
<!-- eslint-disable no-unused-vars -->

```js
var parseRange = require('range-parser')
var parseRange = require("range-parser");
```

### parseRange(size, header, options)
Expand All @@ -32,21 +32,19 @@ Parse the given `header` string where `size` is the size of the selected
representation that is to be partitioned into subranges. An array of subranges
will be returned or negative numbers indicating an error parsing.

* `-2` signals a malformed header string
* `-1` signals an unsatisfiable range

<!-- eslint-disable no-undef -->
- `-2` signals a malformed header string
- `-1` signals an unsatisfiable range

```js
// parse header from request
var subranges = parseRange(size, req.headers.range)
var subranges = parseRange(size, req.headers.range);

// the type of the subranges
if (subranges.type === 'bytes') {
if (subranges.type === "bytes") {
// the ranges
subranges.forEach(function (r) {
// do something with r.start and r.end
})
});
}
```

Expand All @@ -60,10 +58,8 @@ Specifies if overlapping & adjacent subranges should be combined, defaults to
`false`. When `true`, ranges will be combined and returned as if they were
specified that way in the header.

<!-- eslint-disable no-undef -->

```js
parseRange(100, 'bytes=50-55,0-10,5-10,56-60', { combine: true })
parseRange(100, "bytes=50-55,0-10,5-10,56-60", { combine: true });
// => [
// { start: 0, end: 10 },
// { start: 50, end: 60 }
Expand Down
Loading
Loading