How to add "URIUniversalCommunication" at Seller / Buyer TradeContact

[davewwww]

To Reproduce

I have generated an xml with ProfileEN16931 with date from your test case: en16931.ts

Here the exported XML: EN16931.xml.txt

When I validate this XML by using the KoSIT validator, several warnings are reported.

Current vs. Expected behavior

the report says:

Pos	Code	Adj. Grad	Text	Pfad
val-sch.2.2	PEPPOL-EN16931-R020	information	Seller electronic address MUST be provided	/rsm:CrossIndustryInvoice/rsm:SupplyChainTradeTransaction[1]/ram:ApplicableHeaderTradeAgreement[1]/ram:SellerTradeParty[1]
val-sch.2.2	PEPPOL-EN16931-R010	information	Buyer electronic address MUST be provided	/rsm:CrossIndustryInvoice/rsm:SupplyChainTradeTransaction[1]/ram:ApplicableHeaderTradeAgreement[1]/ram:BuyerTradeParty[1]

so at the <SellerTradeParty> is this tag missing:

        <ram:URIUniversalCommunication>
          <ram:URIID schemeID="EM">[email protected]</ram:URIID>
        </ram:URIUniversalCommunication>

how can i add this required electronic address? as i can see, there is no schema available.

        seller: {
          name: 'Groß und Breit Bau AG',
          postalAddress: {
            postCode: '12345',
            line1: 'Erdkuhl 5',
            city: 'Berlin',
            countryCode: 'DE',
            electronicAddress: '[email protected]',
            emailAddress: '[email protected]',
          },
          taxRegistration: {
            vatIdentifier: 'DE999999999',
          },
          tradeContact: {
            name: 'Hans Muster',
            departmentName: 'BT-41-0',
            phoneNumber: '012378945641',
            email: '[email protected]',
            emailAddress: '[email protected]',
            electronicAddress: '[email protected]',
          },
          email: '[email protected]',
          electronicAddress: '[email protected]',
          emailAddress: '[email protected]',
        },

Do I have to create my own profile? Is anything missing there? Am I doing something wrong?

thx for your help.

What version of node-zugferd are you using?

0.0.8

Provide environment information

node 22

Which area(s) are affected? (Select all that apply)

Other, Types

Config (if applicable)

import { zugferd } from "node-zugferd";
import { BASIC } from "node-zugferd/profile/basic";

export const invoicer = zugferd({
  profile: BASIC
})

[jslno]

The warnings are for the XRechnung schema, which currently is not supported by default. If you dont require xrechnung compliance you can safely ignore this and use the emailAddress field inside tradeContact

[davewwww]

yes, XRechnung is target schema i have to achieve.

  <rsm:ExchangedDocumentContext>
    <ram:BusinessProcessSpecifiedDocumentContextParameter>
      <ram:ID>urn:fdc:peppol.eu:2017:poacc:billing:01:1.0</ram:ID>
    </ram:BusinessProcessSpecifiedDocumentContextParameter>
    <ram:GuidelineSpecifiedDocumentContextParameter>
      <ram:ID>urn:cen.eu:en16931:2017#compliant#urn:xeinkauf.de:kosit:xrechnung_3.0</ram:ID>
    </ram:GuidelineSpecifiedDocumentContextParameter>
  </rsm:ExchangedDocumentContext>

[jslno]

To achieve this you'd currently have to create your own profile. For reference, you can take a look at
https://github.com/jslno/node-zugferd/tree/main/packages/node-zugferd/src/profiles
https://node-zugferd.jsolano.de/docs/guides/create-your-first-profile (bit outdated)

[davewwww]

I've already tried that, but I'm struggling already with importing all the necessary stuff. importing createProfile - its not exported. Also, all the other imports in the profile files look very much like local imports.

import { createProfile } from "../factory";
import { type InferSchema } from "../../types/schema";
import { BASIC } from "../basic";
import { en16931Schema } from "./schema";
import { getAsset } from "../../utils/asset";
import { en16931Mask } from "./mask";
...
import { type Schema } from "../../types/schema";
import { dateTimeStringFormatter } from "../../utils/helper";
import { UNTDID_1153 } from "../../codelists/untdid/1153.gen";
import { UNTDID_7143 } from "../../codelists/untdid/7143.gen";
import { ISO_3166 } from "../../codelists/iso/3166";

Unfortunately, I don't see a way to build this right now without a deeper understanding of your library.

[jslno]

The factory import is fixed in v0.0.9-beta.1

import { createProfile, dateTimeStringFormatter } from "node-zugferd/profile";
import type { Schema, InferSchema } from "node-zugferd/types";
import { EN16931 } from "node-zugferd/profile/en16931";
EN16931.schema;
import { /* ... */ } from "node-zugferd/codelist/<CODELIST>"; // See docs

getAsset is only used internally. you could use path.resolve to your XRechnung xsd (if you opt out of this the library wont handle validation).

To use the mask you can simply copy it from the source code, they aren't extendable because they define the order of the fields.