Skip to content

Discriminator variant disapears when type name is overridden #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
g6123 opened this issue Jan 27, 2023 · 0 comments
Open

Discriminator variant disapears when type name is overridden #65

g6123 opened this issue Jan 27, 2023 · 0 comments

Comments

@g6123
Copy link

g6123 commented Jan 27, 2023

This schema with custom type name in metadata field:

{
  "discriminator": "eventType",
  "mapping": {
    "USER_CREATED": {
      "metadata": {
        "typescriptType": "UserCreatedEvent",
        "pythonType": "UserCreatedEvent"
      },
      "properties": {
        "id": {
          "type": "string"
        }
      }
    },
    "USER_DELETED": {
      "properties": {
        "id": {
          "type": "string"
        },
        "softDelete": {
          "type": "boolean"
        }
      }
    }
  }
}

does not generate discriminated variant USER_CREATED:

export type Test = TestUserCreated | TestUserDeleted;

export interface TestUserDeleted {
  eventType: "USER_DELETED";
  id: string;
  softDelete: boolean;
}
@dataclass
class Test:
    event_type: 'str'

    @classmethod
    def from_json_data(cls, data: Any) -> 'Test':
        variants: Dict[str, Type[Test]] = {
            "USER_CREATED": TestUserCreated,
            "USER_DELETED": TestUserDeleted,
        }
        return variants[data["eventType"]].from_json_data(data)

    # ...

@dataclass
class TestUserDeleted(Test):
    id: 'str'
    soft_delete: 'bool'
    # ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant