Skip to content

fix images encoding in dist zip #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 4, 2025
Merged

fix images encoding in dist zip #3615

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28de6ec
fix images encoding in dist zip
Jolg42 Oct 12, 2025
2ee865d
add changeset
Jolg42 Oct 12, 2025
1298e33
set @jspsych/config for changeset
Jolg42 Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/stale-falcons-grin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"jspsych": patch
---

fix images encoding in dist zip
10 changes: 8 additions & 2 deletions packages/config/gulp.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,8 @@ export const createCoreDistArchive = () =>
src("packages/plugin-survey/css/survey.css").pipe(rename("/dist/survey.css")),
src("packages/plugin-survey/css/survey.min.css").pipe(rename("/dist/survey.min.css")),

// Examples
src("examples/**/*", { base: "." })
// Examples HTML files
src(["examples/**/*.html"], { base: "." })
// Rewrite script source paths
.pipe(
replace(
Expand All @@ -103,6 +103,12 @@ export const createCoreDistArchive = () =>
)
),

// Examples files other than HTML (e.g. media files)
// Note: `encoding: false` means that the files contents are treated as binary.
// This prevents Gulp from corrupting binary files such as images when it reads them.
// Needed since Gulp v5.
src(["examples/**/*", "!examples/**/*.html"], { base: ".", encoding: false }),

// VERSION.md
file("VERSION.md", getVersionFileContents(), { src: true }),

Expand Down