Skip to content

Commit e4b759a

Browse files
authored
docs: fix rewrite rule region notes
1 parent 7f59de6 commit e4b759a

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

README.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -639,7 +639,8 @@ Choice is a good thing, hopefully this comparison table helps you decide which c
639639
| ----------------------------------------------------------------- | ------------------ | --------------------------------------------------------------------------------------------------- |
640640
| Firebase Emulator Integration | :heavy_check_mark: | :x: |
641641
| Unified deployment - Firebase Hosting & Compute deployed together | :heavy_check_mark: | :x: |
642-
| Cold start mitigations | :x: stay tuned | :heavy_check_mark: ([`min_instances`](https://cloud.google.com/run/docs/configuring/min-instances)) |
642+
| Cold start mitigations | :x: (stay tuned) | :heavy_check_mark: ([`min_instances`](https://cloud.google.com/run/docs/configuring/min-instances)) |
643+
| Regions | :x: only ```us-central1``` shown in [docs](https://firebase.google.com/docs/hosting/functions) (stay tuned) | :heavy_check_mark: full list in [docs](https://firebase.google.com/docs/hosting/full-config#rewrite-cloud-run-container) |
643644

644645
Cloud Functions seems do be a better default, with some improvements coming in the future.
645646

@@ -682,7 +683,7 @@ If cold starts are still an issue for your application, Cloud Run has support fo
682683
## Caveats
683684

684685
- [Firebase Hosting Preview Channels](https://firebase.google.com/docs/hosting/test-preview-deploy) currently lacks first-party support for SSR applications. This adapter doesn't attempt to remedy this issue and doesn't produce a different SSR Function/Run for preview channel deployments.
685-
- :warning: while you can specify the region for both, Cloud Run in `firebase.json:run.region` and Cloud Functions in the `runWith({region: ""})` function definition, **`us-central1` is the only valid region for Firebase Hosting rewrites**, other regions will error. The official warning about this can be found in [these docs](https://firebase.google.com/docs/hosting/functions).
686+
- :warning: Cloud Function rewrites only support **us-central1**, other regions will error. The official warning about this can be found in [these docs](https://firebase.google.com/docs/hosting/functions).
686687
<!-- TODO: on 1.0.0 release, delete this section -->
687688
- `1.0.0` will not be published until the SvelteKit Adapter API is declared stable and SvelteKit is released for general use.
688689
<!-- END -->

0 commit comments

Comments
 (0)