Skip to content

Update rawBody #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benmccann opened this issue Aug 17, 2021 · 3 comments · Fixed by #123
Closed

Update rawBody #122

benmccann opened this issue Aug 17, 2021 · 3 comments · Fixed by #123
Labels
bug Something isn't working

Comments

@benmccann
Copy link

Describe the Bug

See sveltejs/kit#2215

You'll need to update

const finalRawBody =

This is the last breaking change on the 1.0 milestone affecting SvelteKit adapters, so while no promises, hopefully there won't be any more changes required after this

Thanks for providing this adapter!

Steps to Reproduce

look at source code

Expected Behaviour

uses latest SvelteKit API

svelte-adapter-firebase version

n/a

sveltejs/kit version

latest

@benmccann benmccann added the bug Something isn't working label Aug 17, 2021
@jthegedus
Copy link
Owner

will get on this soon, thanks for the report 👍

@jthegedus
Copy link
Owner

jthegedus commented Aug 19, 2021

@benmccann I want to type render from import {init,render} from '../output/server/app.js'; to ensure my adapter matches the correct types, is this possible? I am unsure if App.init and App.render are the correct types and if they can/should be exposed?

Edit: I think I found the type for render with import('@sveltejs/kit/types/internal').Incoming?

@jthegedus
Copy link
Owner

Thanks for your help on this 🙏 Hopefully my new rawBody code is correct 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants