Solhint: separate config for /test/ /script/ etc

[filmakarov]

Solhint allows having several configs for different folders of the same project (not speaking of monorepos here).

The most common use case for this is having relaxed rules for the test folder.

However, Solidity extension doesn't pickup the subdir configs. It leads to the issue that CLI linter is fine, while IDE visual linter produces multiple warnings and errors for the test files.

Potential solutions, in order of preference:

1. allow extension to handle subdir configs
2. introduce solidity.solhintIgnore setting, so I can ignore test folder for visual linting
3. allow rules configured in the solidity.solhintRules setting to have priority on the .solhint.json rules. this will allow ignoring some rules at least visually and have less visual noise

[0xcompose]

Requested update of solhint dependency in #481

[filmakarov]

hey @0xcompose thank you for answering

I am already using solhint 6.0.1
And my point is actually that with solhint I am using multiple configs (see the very first paragraph in my initial message)
However the Solidity extension does not take the configs in the subfolders into account.

Am I missing something here?

[0xcompose]

Here is the issue, you're using solhint 6.0.1, but Solidity extension uses 5.0.5, which specified in package.json in master branch (screenshot attached)

To allow new features of solhint to take place - update of solhint version in extension itself is required. Which was implemented by TateB, but not yet reviewed and merged by @juanfranblanco

Hope I helped you understand the issue and what's blocking the updates 🙌

[filmakarov]

ah, makes sense. Thanks for the clarifications, I misunderstood your original message.
Awesome that was requested and even implemented already, just needs to be merged.
Can safely close this issue then and wait for the new release with solhint 6+