use function call to replace goto (#4414)

Author: davies

pkg/object/ufile.go

@@ -176,15 +176,13 @@ func (u *ufile) Copy(dst, src string) error {
 	uri := fmt.Sprintf("uploadhit?Hash=%s&FileName=%s&FileSize=%s", hash, dst, lens[0])
 	resp, err = u.request("POST", uri, nil, nil)
 	if err != nil {
-		goto fallback
+		return copyObj(u, dst, src)
 	}
 	defer cleanup(resp)
 	if resp.StatusCode != 200 {
-		goto fallback
+		return copyObj(u, dst, src)
 	}
 	return nil
-fallback:
-	return copyObj(u, dst, src)
 }
 
 type DataItem struct {

pkg/sync/sync.go

@@ -371,7 +371,7 @@ func doCopySingle(src, dst object.ObjectStorage, key string, size int64) error {
 			// download the object into disk
 			if f, err = os.CreateTemp("", "rep"); err != nil {
 				logger.Warnf("create temp file: %s", err)
-				goto SINGLE
+				return doCopySingle0(src, dst, key, size)
 			}
 			_ = os.Remove(f.Name()) // will be deleted after Close()
 			defer f.Close()
@@ -394,7 +394,10 @@ func doCopySingle(src, dst object.ObjectStorage, key string, size int64) error {
 		}
 		return err
 	}
-SINGLE:
+	return doCopySingle0(src, dst, key, size)
+}
+
+func doCopySingle0(src, dst object.ObjectStorage, key string, size int64) error {
 	if limiter != nil {
 		limiter.Wait(size)
 	}