Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS support #33

Merged
merged 5 commits into from
Jan 21, 2025
Merged

Add HTTPS support #33

merged 5 commits into from
Jan 21, 2025

Conversation

omus
Copy link
Contributor

@omus omus commented Jan 17, 2025

Fixes #20. Supports authenticating via HTTPS when a PAT is provided. I've ended up making this change a breaking change since I renamed the input key to ssh-key for clarity.

@christopher-dG
Copy link
Member

@omus do you reckon we could deprecate key rather than removing it? i.e. the value is basically inputs.ssh-key || inputs.key for now

@omus
Copy link
Contributor Author

omus commented Jan 20, 2025

@omus do you reckon we could deprecate key rather than removing it? i.e. the value is basically inputs.ssh-key || inputs.key for now

I can definitely do that. My thought was if someone wants to use this new feature they would be updating their workflows anyway

@omus
Copy link
Contributor Author

omus commented Jan 20, 2025

I've done some manual validation in a private repo that using protocol: https works and that protocol: ssh works correctly with either ssh-key or key (for backwards compatibility).

@christopher-dG christopher-dG merged commit 90c4bf9 into julia-actions:main Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support cloning private registries with HTTPS
2 participants