From 1aec431e0235ee43e194f927a5f4c04261a10fcb Mon Sep 17 00:00:00 2001 From: Eric Hanson <5846501+ericphanson@users.noreply.github.com> Date: Sun, 2 Apr 2023 23:23:43 +0200 Subject: [PATCH] Restrict annotation functionality to versions of Julia it works on (#79) * Restrict annotation functionality to versions of Julia it works on see #76 * Update README.md --- README.md | 3 ++- action.yml | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 0319bd9..feda4ca 100644 --- a/README.md +++ b/README.md @@ -45,7 +45,8 @@ jobs: You can add this workflow to your repository by placing it in a file called `test.yml` in the folder `.github/workflows/`. [More info here](https://docs.github.com/en/actions/reference/workflow-syntax-for-github-actions). Here, setting `annotate: true` causes GitHub "annotations" to appear when reviewing the PR, pointing to failing tests, if any. -Note that this impacts stacktraces in case of errors (see #76). +This functionality is only enabled on Julia 1.8 (even if `annotate` is set to `true`), since currently it does not work on other Julia versions (see #76). + By default, `annotate` is set to false, but that may change in future releases of this action. ### Prefixing the Julia command diff --git a/action.yml b/action.yml index 0b59265..f342746 100644 --- a/action.yml +++ b/action.yml @@ -41,7 +41,8 @@ runs: shell: bash - name: Install dependencies in their own (shared) environment run: | - if VERSION > v"1.8pre" + # Functionality only currently works on a narrow range of Julia versions... see #76 + if v"1.8pre" < VERSION < v"1.9.0-beta3" using Pkg Pkg.activate("tests-logger-env"; shared=true) Pkg.add(Pkg.PackageSpec(name="GitHubActions", version="0.1"))