Simplify GDXFile constructor and add setters (#5)

Author: mitchphillipson

src/GDXFile.jl

@@ -145,6 +145,10 @@ function GDXFile(path::String, symbols::Dict{Symbol, <:GDXSymbol})
     return gdx
 end
 
+function GDXFile(path::String)
+    return GDXFile(path, Dict{Symbol, GDXSymbol}(), Symbol[])
+end
+
 function _insert!(gdx::GDXFile, key::Symbol, sym::GDXSymbol)
     lk = _symkey(key)
     if !haskey(gdx._symbols, lk)
@@ -200,6 +204,10 @@ Base.haskey(gdx::GDXFile, sym::Symbol) = haskey(gdx._symbols, _symkey(sym))
 Base.keys(gdx::GDXFile) = Symbol[Symbol(gdx._symbols[k].name) for k in gdx._order]
 Base.length(gdx::GDXFile) = length(gdx._order)
 
+# Dictionary-like setting (inserts or updates symbols)
+Base.setindex!(gdx::GDXFile, sym::GDXSymbol, key::Symbol) = _insert!(gdx, key, sym)
+Base.setindex!(gdx::GDXFile, sym::GDXSymbol, key::String) = _insert!(gdx, Symbol(key), sym)
+
 function Base.iterate(gdx::GDXFile)
     isempty(gdx._order) && return nothing
     k = gdx._order[1]

test/test_gdxfile.jl

@@ -522,4 +522,24 @@ execute_unload "gams_gdx_test.gdx", i, p, x, y;
 
         rm(outfile, force=true)
     end
+
+
+    @testset "Setting symbols via indexing" begin
+        gdxfile = GDXFile("")
+
+        df = DataFrame(i = ["a", "b"], value = [1.0, 2.0])
+        p = GDXParameter("p", "test param", ["i"], df)
+        gdxfile[:p] = p
+
+        @test :p in list_parameters(gdxfile)
+        @test gdxfile[:p].value == [1.0, 2.0]
+
+        # String keys should also work
+        df2 = DataFrame(j = ["x", "y"], value = [3.0, 4.0])
+        p2 = GDXParameter("q", "another param", ["j"], df2)
+        gdxfile["q"] = p2
+
+        @test :q in list_parameters(gdxfile)
+        @test gdxfile[:q].value == [3.0, 4.0]
+    end
 end