Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gurobi v11 artifact for CI testing #536

Merged
merged 5 commits into from
Dec 2, 2023
Merged

Add Gurobi v11 artifact for CI testing #536

merged 5 commits into from
Dec 2, 2023

Conversation

simonbowly
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4f68112) 75.89% compared to head (d182d22) 75.89%.

❗ Current head d182d22 differs from pull request most recent head a71d8ea. Consider uploading reports for the commit a71d8ea to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #536   +/-   ##
=======================================
  Coverage   75.89%   75.89%           
=======================================
  Files           6        6           
  Lines        2900     2900           
=======================================
  Hits         2201     2201           
  Misses        699      699           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@odow
Copy link
Member

odow commented Dec 1, 2023

I hadn't thought about this before. But this is breaking if someone was using the automatic download of Gurobi on linux, and they update their package version without updating their license. This is probably okay for now, because we shouldn't have too many people affected and it's a simple change.

But longer term, I wonder about syncing the major version of Gurobi.jl with Gurobi, so this would become v11.0.0. The downside is then we'd only ever support the latest major version, unless we back ported fixes to Gurobi.jl v10.X.Y.

@simonbowly
Copy link
Collaborator Author

I also missed the fallback path for the artifact in the library loader. That's updated now, so I think things are working as expected this time.

@odow
Copy link
Member

odow commented Dec 2, 2023

Confirm that I see Gurobi Optimizer version 11.0.0 build v11.0.0rc2 (linux64 - "Ubuntu 22.04.3 LTS")

@odow odow merged commit f4477c9 into master Dec 2, 2023
@odow odow deleted the v11-CI branch December 2, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants