Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] exclude Gurobi examples if built from fork #3919

Merged
merged 6 commits into from
Jan 27, 2025
Merged

[docs] exclude Gurobi examples if built from fork #3919

merged 6 commits into from
Jan 27, 2025

Conversation

odow
Copy link
Member

@odow odow commented Jan 19, 2025

Closes #3917

Copy link

codecov bot commented Jan 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.58%. Comparing base (7c45f40) to head (b5db8a1).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3919   +/-   ##
=======================================
  Coverage   99.58%   99.58%           
=======================================
  Files          43       43           
  Lines        6059     6059           
=======================================
  Hits         6034     6034           
  Misses         25       25           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joaquimg
Copy link
Member

This add a route to break master, right?
Merging external PRs will need an extra check if Gurobi stuff is not touched.

@odow
Copy link
Member Author

odow commented Jan 23, 2025

Yeah. I need to find a better approach. Maybe I can #src some checks to the actual tutorials, rather than excluding them.

@odow odow marked this pull request as draft January 23, 2025 01:39
@odow
Copy link
Member Author

odow commented Jan 26, 2025

Closing in favor of #3924

@odow odow closed this Jan 26, 2025
@odow odow reopened this Jan 26, 2025
@odow odow marked this pull request as ready for review January 26, 2025 21:52
@odow odow merged commit 6e4427a into master Jan 27, 2025
11 checks passed
@odow odow deleted the od/grb branch January 27, 2025 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Gurobi in the docs means forks will fail
2 participants