From a7cbccdd38c099b793e8a4b4b7d052ffa0de7c34 Mon Sep 17 00:00:00 2001
From: odow <o.dowson@gmail.com>
Date: Tue, 22 Oct 2024 13:40:10 +1300
Subject: [PATCH 1/4] Disallow querying is_set_by_optimize attributes unless
 explicitly supported

---
 src/MultiObjectiveAlgorithms.jl |  8 ++++++++
 test/test_model.jl              | 24 ++++++++++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/src/MultiObjectiveAlgorithms.jl b/src/MultiObjectiveAlgorithms.jl
index 74ede13..85f4cf4 100644
--- a/src/MultiObjectiveAlgorithms.jl
+++ b/src/MultiObjectiveAlgorithms.jl
@@ -446,10 +446,18 @@ function MOI.set(model::Optimizer, attr::_ATTRIBUTES, args...)
 end
 
 function MOI.get(model::Optimizer, attr::_ATTRIBUTES, args...)
+    if MOI.is_set_by_optimize(attr)
+        msg = "MOA does not support querying this attribute."
+        throw(MOI.GetAttributeNotAllowed(attr, msg))
+    end
     return MOI.get(model.inner, attr, args...)
 end
 
 function MOI.get(model::Optimizer, attr::_ATTRIBUTES, arg::Vector{T}) where {T}
+    if MOI.is_set_by_optimize(attr)
+        msg = "MOA does not support querying this attribute."
+        throw(MOI.GetAttributeNotAllowed(attr, msg))
+    end
     return MOI.get.(model, attr, arg)
 end
 
diff --git a/test/test_model.jl b/test/test_model.jl
index 827e854..8360b3d 100644
--- a/test/test_model.jl
+++ b/test/test_model.jl
@@ -100,6 +100,30 @@ function test_solve_time()
     return
 end
 
+function test_unnsupported_attributes()
+    model = MOA.Optimizer(HiGHS.Optimizer)
+    MOI.set(model, MOI.Silent(), true)
+    x = MOI.add_variables(model, 2)
+    c = MOI.add_constraint.(model, x, MOI.GreaterThan(0.0))
+    f = MOI.Utilities.operate(vcat, Float64, 1.0 .* x...)
+    MOI.set(model, MOI.ObjectiveFunction{typeof(f)}(), f)
+    MOI.set(model, MOI.ObjectiveSense(), MOI.MAX_SENSE)
+    MOI.optimize!(model)
+    @test_throws(
+        MOI.GetAttributeNotAllowed{MOI.RelativeGap},
+        MOI.get(model, MOI.RelativeGap()),
+    )
+    @test_throws(
+        MOI.GetAttributeNotAllowed{MOI.DualObjectiveValue},
+        MOI.get(model, MOI.DualObjectiveValue()),
+    )
+    @test_throws(
+        MOI.GetAttributeNotAllowed{MOI.ConstraintDual},
+        MOI.get(model, MOI.ConstraintDual(), c),
+    )
+    return
+end
+
 end
 
 TestModel.run_tests()

From d2e055047a32679652f3efc5004f708c5901a366 Mon Sep 17 00:00:00 2001
From: odow <o.dowson@gmail.com>
Date: Tue, 22 Oct 2024 13:56:47 +1300
Subject: [PATCH 2/4] Update

---
 src/MultiObjectiveAlgorithms.jl | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/src/MultiObjectiveAlgorithms.jl b/src/MultiObjectiveAlgorithms.jl
index 85f4cf4..3394128 100644
--- a/src/MultiObjectiveAlgorithms.jl
+++ b/src/MultiObjectiveAlgorithms.jl
@@ -577,6 +577,15 @@ function MOI.get(
     return sol.x[x]
 end
 
+function MOI.get(
+    model::Optimizer,
+    attr::MOI.VariablePrimal,
+    x::Vector{MOI.VariableIndex}
+)
+    sol = model.solutions[attr.result_index]
+    return sol.x[x]
+end
+
 function MOI.get(model::Optimizer, attr::MOI.ObjectiveValue)
     return model.solutions[attr.result_index].y
 end

From 2120d665f19a81900a9cf86162905afc593e0b58 Mon Sep 17 00:00:00 2001
From: odow <o.dowson@gmail.com>
Date: Tue, 22 Oct 2024 14:07:32 +1300
Subject: [PATCH 3/4] Update

---
 src/MultiObjectiveAlgorithms.jl | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/src/MultiObjectiveAlgorithms.jl b/src/MultiObjectiveAlgorithms.jl
index 3394128..eb84b85 100644
--- a/src/MultiObjectiveAlgorithms.jl
+++ b/src/MultiObjectiveAlgorithms.jl
@@ -582,8 +582,7 @@ function MOI.get(
     attr::MOI.VariablePrimal,
     x::Vector{MOI.VariableIndex}
 )
-    sol = model.solutions[attr.result_index]
-    return sol.x[x]
+    return MOI.get.(model, attr, x)
 end
 
 function MOI.get(model::Optimizer, attr::MOI.ObjectiveValue)

From f61cb8132c8d3f9c11b58b691042b0fa4b370cb9 Mon Sep 17 00:00:00 2001
From: odow <o.dowson@gmail.com>
Date: Tue, 22 Oct 2024 14:08:22 +1300
Subject: [PATCH 4/4] Fix

---
 src/MultiObjectiveAlgorithms.jl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/MultiObjectiveAlgorithms.jl b/src/MultiObjectiveAlgorithms.jl
index eb84b85..32ca9fb 100644
--- a/src/MultiObjectiveAlgorithms.jl
+++ b/src/MultiObjectiveAlgorithms.jl
@@ -580,7 +580,7 @@ end
 function MOI.get(
     model::Optimizer,
     attr::MOI.VariablePrimal,
-    x::Vector{MOI.VariableIndex}
+    x::Vector{MOI.VariableIndex},
 )
     return MOI.get.(model, attr, x)
 end