Add METADATA of instances #44
Open
+808
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datejada
reviewed
Jan 21, 2025
datejada
reviewed
Jan 21, 2025
datejada
reviewed
Jan 21, 2025
datejada
reviewed
Jan 21, 2025
datejada
reviewed
Jan 21, 2025
datejada
reviewed
Jan 21, 2025
datejada
reviewed
Jan 21, 2025
Co-authored-by: Diego Alejandro Tejada Arango <[email protected]>
datejada
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Hi @joaquimg, I left some changes for your review.
I don´t know if it makes sense to add an extra field with the number of total elements/components (e.g., generators + lines + others) in each case study. Since you can have few nodes but a high number of elements, this also adds to the complexity of the problem. If so, let me know and I can help with the Tulipa and SpineOpt ones.
Thanks!
|
Your suggestions make total sense. Just integrated them. About summing the number of elements it might be painful for other models, but it is something to consider. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #42
cc @datejada @jd-lara @iSoron