Skip to content

Commit af6593d

Browse files
committed
add pointers to upstream galata helpers
1 parent 4027283 commit af6593d

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

ui-tests/tests/unified-cell-diff.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,9 @@ async function setupCellWithUnifiedDiff(
3131

3232
/**
3333
* Get the content of the first cell in the active notebook.
34+
*
35+
* TODO: use getCellTextInput from galata?
36+
* See https://github.com/jupyterlab/jupyterlab/blob/1abbdf39fb204e47941e8d8021d85366a0ecece9/galata/src/helpers/notebook.ts#L677-L707
3437
*/
3538
async function getCellContent(page: IJupyterLabPageFixture): Promise<string> {
3639
return await page.evaluate(() => {

ui-tests/tests/unified-file-diff.spec.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ async function setupFileWithUnifiedDiff(
3232

3333
/**
3434
* Get the content of the current file in the editor.
35+
*
36+
* TODO: follow the same approach as in JupyterLab, with getEditorText?
37+
* See https://github.com/jupyterlab/jupyterlab/blob/1abbdf39fb204e47941e8d8021d85366a0ecece9/galata/test/jupyterlab/file-edit.test.ts#L73-L85
3538
*/
3639
async function getFileContent(page: IJupyterLabPageFixture): Promise<string> {
3740
return await page.evaluate(() => {

0 commit comments

Comments
 (0)