Skip to content

Commit 3a4ceca

Browse files
committed
Revert "More clearly specify how we look for v6 notebook packages"
This commit caused the *notebook* downstream version check to fail, which makes sense? This reverts commit 40029a7.
1 parent 40029a7 commit 3a4ceca

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

jupyter_server/prometheus/metrics.py

+2-5
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,13 @@
1010

1111
try:
1212
from notebook._version import version_info as notebook_version_info
13-
v6_notebook_present = notebook_version_info != server_version_info
1413
except ImportError:
15-
# notebook._version is not present, so notebook v6 can not be present
16-
v6_notebook_present = False
14+
notebook_version_info = None
1715

1816

19-
if v6_notebook_present:
17+
if notebook_version_info is not None and notebook_version_info < (7,) and notebook_version_info != server_version_info:
2018
print("yes, we think we have an unshimmed notebook package")
2119
print(notebook_version_info)
22-
print(server_version_info)
2320
# Jupyter Notebook v6 also defined these metrics. Re-defining them results in a ValueError,
2421
# so we simply re-export them if we are co-existing with the notebook v6 package.
2522
# See https://github.com/jupyter/jupyter_server/issues/209

0 commit comments

Comments
 (0)