review comments

Author: Zsailer

jupyter_server/services/events/handlers.py

@@ -13,11 +13,11 @@
 AUTH_RESOURCE = "events"
 
 
-class TornadoWebSocketLoggingHandler(logging.Handler):
+class WebSocketLoggingHandler(logging.Handler):
     """Python logging handler that routes records to a Tornado websocket."""
 
-    def __init__(self, websocket):
-        super().__init__()
+    def __init__(self, websocket, *args, **kwargs):
+        super().__init__(*args, **kwargs)
         self.websocket = websocket
 
     def emit(self, record):
@@ -62,7 +62,7 @@ def open(self):
         """Routes events that are emitted by Jupyter Server's
         EventBus to a WebSocket client in the browser.
         """
-        self.logging_handler = TornadoWebSocketLoggingHandler(self)
+        self.logging_handler = WebSocketLoggingHandler(self)
         # Add a JSON formatter to the handler.
         formatter = jsonlogger.JsonFormatter(json_serializer=_skip_message)
         self.logging_handler.setFormatter(formatter)
@@ -72,6 +72,7 @@ def open(self):
 
     def on_close(self):
         self.event_bus.log.removeHandler(self.logging_handler)
+        self.event_bus.handlers.remove(self.logging_handler)
 
 
 default_handlers = [