Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zmq.Poller is not async #1022

Closed
fcollonval opened this issue May 14, 2024 · 1 comment · Fixed by #1023
Closed

zmq.Poller is not async #1022

fcollonval opened this issue May 14, 2024 · 1 comment · Fixed by #1023

Comments

@fcollonval
Copy link
Contributor

The line

jupyter_client/jupyter_client/client.py

Line 533 in 0a19278

poller = zmq.Poller()
makes the code blocking.

We should use zmq.asyncio.Poller.
@fcollonval
Copy link
Contributor Author

Seen when working on https://github.com/datalayer/jupyter-server-nbmodel, when manually testing the code, jupyter-server requests are blocked.

@fcollonval fcollonval mentioned this issue May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use non-blocking zmq Poller fcollonval/jupyter_client
1 participant
@fcollonval