Raise TimeoutError instead of RuntimeError

[edwardzjl]

This is more of a question than a bug report.

In

jupyter_client/jupyter_client/client.py

Line 178 in 80c6367

raise RuntimeError(

and

jupyter_client/jupyter_client/client.py

Line 207 in 80c6367

raise RuntimeError("Kernel didn't respond in %d seconds" % timeout)

a RuntimeError is raised when a timeout occurs, rather than a TimeoutError.

However in other places, such as

jupyter_client/jupyter_client/client.py

Line 232 in 80c6367

raise TimeoutError(msg) from e

and

jupyter_client/jupyter_client/client.py

Line 550 in 80c6367

raise TimeoutError(emsg)

, a TimeoutError is raised.

Is it intentional that a RuntimeError is raised during the wait_for_ready stage instead of a TimeoutError?

[minrk]

I believe the RuntimeError predates the existence of TimeoutError, added in Python 3.3. It does make sense to use TimeoutError, though changing it now would technically be a breaking change, as code that caught this error would no longer catch it.

[edwardzjl]

Thank you for the clarification! I’ll close this issue now.