Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BlockingKernelClient #533

Closed
davidbrochart opened this issue Mar 19, 2020 · 4 comments
Closed

Refactor BlockingKernelClient #533

davidbrochart opened this issue Mar 19, 2020 · 4 comments
Milestone

Comments

@davidbrochart
Copy link
Member

There is a lot of code duplication between AsyncKernelClient and BlockingKernelClient. BlockingKernelClient's methods could be wrappers around AsyncKernelClient's methods, which would run the later until complete.
What do you think?

@MSeal
Copy link
Contributor

MSeal commented Mar 19, 2020

I think that'd be a good idea, but maybe let's hold off making this low level infrastructure do that until 3.5 gets dropped? I'm a little worried with the hangs for 3.5 we saw in nbconvert after async change -- that one is doing a major version bump so I'm more ok with it but here we might want to wait for a major version change / 3.5 being gone before taking that risk on?

@davidbrochart
Copy link
Member Author

Sure, that sounds reasonable.

@blink1073
Copy link
Contributor

@davidbrochart is there any more work to be done on this front for 7.0?

@davidbrochart
Copy link
Member Author

No, it has been done in #623. Closing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants