You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a lot of code duplication between AsyncKernelClient and BlockingKernelClient. BlockingKernelClient's methods could be wrappers around AsyncKernelClient's methods, which would run the later until complete.
What do you think?
The text was updated successfully, but these errors were encountered:
I think that'd be a good idea, but maybe let's hold off making this low level infrastructure do that until 3.5 gets dropped? I'm a little worried with the hangs for 3.5 we saw in nbconvert after async change -- that one is doing a major version bump so I'm more ok with it but here we might want to wait for a major version change / 3.5 being gone before taking that risk on?
There is a lot of code duplication between
AsyncKernelClient
andBlockingKernelClient
.BlockingKernelClient
's methods could be wrappers aroundAsyncKernelClient
's methods, which would run the later until complete.What do you think?
The text was updated successfully, but these errors were encountered: