Skip to content

Commit 9a12d17

Browse files
committed
Don't skip the assignment if a notebook raises an exception
1 parent 3a44ef4 commit 9a12d17

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

nbgrader/converters/base.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -391,7 +391,7 @@ def _handle_failure(gd: typing.Dict[str, str]) -> None:
391391
self.convert_single_notebook(notebook_filename)
392392

393393
# Exceptions that shouldn't interrupt the entire conversion process should go here
394-
# Those that should go in outer try/except
394+
# Those that should interrupt go in the outer try/except
395395
except UnresponsiveKernelError:
396396
self.log.error(
397397
"While processing assignment %s, the kernel became "
@@ -405,6 +405,7 @@ def _handle_failure(gd: typing.Dict[str, str]) -> None:
405405
errors.append((gd['assignment_id'], gd['student_id']))
406406
_handle_failure(gd)
407407

408+
# Raise unhandled exceptions for the outer try/except
408409
except Exception as e:
409410
raise e
410411

0 commit comments

Comments
 (0)