Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CommandPalette reacts to notifyCommandChanged even when hidden #744

Open
fcollonval opened this issue Mar 4, 2025 · 2 comments · May be fixed by #746
Open

CommandPalette reacts to notifyCommandChanged even when hidden #744

fcollonval opened this issue Mar 4, 2025 · 2 comments · May be fixed by #746
Assignees
@fcollonval
Labels
bug Something isn't working

Comments

@fcollonval
Copy link
Member

fcollonval commented Mar 4, 2025 •
edited
Loading

Description

The command palette is rerendering on notifyCommandChanged even if it is hidden. This triggers a lot of command attribute request for nothing as can be seen by the following warnings:

Image

This is with JupyterLab 4.3.5 with extensions git, lsp and spellchecker activated.

Reproduce

  1. Install jupyterlab-git, jupyterlab-lsp and jupyterlab-spellchecker extensions
  2. Open a notebook in JupyterLab and look at the console log

Note the screenshot was taken after running jupyter lab build --no-minize to introspect the core code.

Expected behavior

The command palette is not rerender when hidden.

Context

Sequence flows:
@fcollonval fcollonval added bug Something isn't working status:Needs Triage labels Mar 4, 2025
@krassowski
Copy link
Member

See:

@fcollonval fcollonval self-assigned this Mar 7, 2025
@fcollonval
Copy link
Member Author

Thanks for the pointers Mike

fcollonval added a commit to fcollonval/lumino that referenced this issue Mar 7, 2025
@fcollonval
Don't refresh if palette is with in a hidden branch
c9e2f2f 
Fixes jupyterlab#744
@fcollonval fcollonval linked a pull request Mar 7, 2025 that will close this issue
Open
fcollonval added a commit to fcollonval/lumino that referenced this issue Mar 21, 2025
@fcollonval
Don't refresh if palette is with in a hidden branch
0ad4841 
Fixes jupyterlab#744
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fcollonval fcollonval

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't refresh if palette is within a hidden branch fcollonval/lumino
2 participants
@krassowski @fcollonval