From 1dce94a8cad9b7909b0923e49c62bfc8f00f41ef Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Mon, 3 Oct 2022 14:08:34 +0000 Subject: [PATCH 1/2] Adding tarfile member sanitization to extractall() --- neuralnet/data_loader.py | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/neuralnet/data_loader.py b/neuralnet/data_loader.py index ffb7840..98a74d5 100644 --- a/neuralnet/data_loader.py +++ b/neuralnet/data_loader.py @@ -89,7 +89,26 @@ def download_dataset(path, source='https://www.cs.toronto.edu/~kriz/' os.makedirs(path) u = urlopen(source) with tarfile.open(fileobj=u, mode='r|gz') as f: - f.extractall(path=path) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner) + + + safe_extract(f, path=path) u.close() From 6cca5b76bbb8b5a4779e8dd7bcc85cde9949ad48 Mon Sep 17 00:00:00 2001 From: TrellixVulnTeam Date: Wed, 5 Oct 2022 01:55:38 +0000 Subject: [PATCH 2/2] Adding numeric_owner as keyword arguement --- neuralnet/data_loader.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/neuralnet/data_loader.py b/neuralnet/data_loader.py index 98a74d5..1926c68 100644 --- a/neuralnet/data_loader.py +++ b/neuralnet/data_loader.py @@ -105,7 +105,7 @@ def safe_extract(tar, path=".", members=None, *, numeric_owner=False): if not is_within_directory(path, member_path): raise Exception("Attempted Path Traversal in Tar File") - tar.extractall(path, members, numeric_owner) + tar.extractall(path, members, numeric_owner=numeric_owner) safe_extract(f, path=path)