Allow unique_with to have reference to BooleanField (#52)

Author: jgadelange

AUTHORS.rst

@@ -39,4 +39,5 @@ generally made django-autoslug better:
 * Peter Baumgartner
 * Jernej Kos
 * Sutrisno Efendi
+* Jeffrey de Lange
 * Your Name Here ;)

autoslug/tests/models.py

@@ -125,6 +125,12 @@ class ModelWithAcceptableEmptyDependency(Model):
     slug = AutoSlugField(unique_with='date')
 
 
+class ModelWithBooleanInUniqueWith(Model):
+    name = CharField(max_length=200)
+    bool = BooleanField()
+    slug = AutoSlugField(unique_with='bool', populate_from='name')
+
+
 class ModelWithAutoUpdateEnabled(Model):
     name = CharField(max_length=200)
     slug = AutoSlugField(populate_from='name', always_update=True)

autoslug/tests/tests.py

@@ -228,6 +228,28 @@ def test_wrong_field_order(self):
         with self.assertRaises(ValueError, msg=errmsg):
             a.save()
 
+    def test_unique_with_boolean_field(self):
+        a = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=True)
+        b = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=False)
+        c = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=False)
+        d = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=True)
+
+        self.assertEqual(a.slug, 'test')
+        self.assertEqual(b.slug, 'test')
+        self.assertEqual(c.slug, 'test-2')
+        self.assertEqual(d.slug, 'test-2')
+
+    def test_unique_with_boolean_field_false_true(self):
+        a = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=False)
+        b = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=True)
+        c = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=False)
+        d = ModelWithBooleanInUniqueWith.objects.create(name='test', bool=True)
+
+        self.assertEqual(a.slug, 'test')
+        self.assertEqual(b.slug, 'test')
+        self.assertEqual(c.slug, 'test-2')
+        self.assertEqual(d.slug, 'test-2')
+
     def test_acceptable_empty_dependency(self):
         model = ModelWithAcceptableEmptyDependency
         instances = [model.objects.create(slug='hello') for x in range(0,2)]

autoslug/utils.py

@@ -115,7 +115,7 @@ def get_uniqueness_lookups(field, instance, unique_with):
                              % (instance._meta.object_name, field_name))
 
         value = getattr(instance, field_name)
-        if not value:
+        if value is not False and not value:
             if other_field.blank:
                 field_object = instance._meta.get_field(field_name)
                 if isinstance(field_object, ForeignKey):