How to close/flush/end ?

[sp00x]

Was just testing this briefly and I notice that the scripts does not automatically close on completion, meaning there's probably some event handler or something that is left hanging, which is different from when using 'pino/file' where it terminates properly.

Is there some close() or end() or something method that needs to be called to make it terminate?

import pino from 'pino';

const transport = pino.transport({
  targets: [
    {
      level: 'trace',
      'target': '@jvddavid/pino-rotating-file',
      options: {
        path: "logs",
        //pattern: "log-%Y-%M-%d-%H-%m-%s-%l-%N.log",
        pattern: "log-%Y-%M-%d-%N.log",
        maxSize: 1024 * 1024 * 10,
        sync: true,
        fsync: true,
        append: true,
        mkdir: true,
      }
    }, 
    // {
    //   level: 'trace',
    //   target: 'pino/file',
    //   options: {
    //     destination: 'test.log'
    //   }
    // },
    {
      level: 'debug',
      target: 'pino-pretty',
      options: {
      }
    }
  ]
});

let logger = pino.pino(transport);

logger.info("hello");

// script is kept open, does not terminate .. terminates properly with pino/file

[1340145680]

Same problem, in my express program I manually restart serve will prompt me the port is occupied, after troubleshooting is due to the pino-rotating-file plugin is not properly closed, in the project compressed into a zip will also be prompted the log file is being used!

[1340145680]

I found the problem, the reason is that SIGINT “does not emit the ‘exit’ event and pino transport cannot call the close method correctly.
pinojs/pino#2002 (comment)

[jvddavid]

Thanks for the feedback, I used the close-with-grace package to perform the stream closure.

import closeWithGrace from 'close-with-grace'
import build from 'pino-abstract-transport'
import { RotateFileStream, type RotateFileTransportOptions } from './RotateFileStream'

export default (opts: RotateFileTransportOptions) => {
  const destination = new RotateFileStream(opts)
  closeWithGrace(() => {
    destination.end()
  })
  return build(
    source => {
      source.pipe(destination)
    },
    {
      close(err, cb) {
        destination.on('close', cb.bind(null, err))
        destination.end()
      },
      parse: 'lines',
      parseLine: line => line
    }
  )
}