From 017c2d27d9a023e80c590d4d6c20e92716ef4b79 Mon Sep 17 00:00:00 2001 From: Ethan Mosbaugh Date: Wed, 12 Feb 2025 10:45:42 -0800 Subject: [PATCH 1/2] fix: kernel modules not enabled, modprobe is not executed Signed-off-by: Ethan Mosbaugh (cherry picked from commit 76ac81248876ab478e93d632484cb398999dc7d0) --- pkg/component/worker/kernelsetup_linux.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/component/worker/kernelsetup_linux.go b/pkg/component/worker/kernelsetup_linux.go index 980ed1cde569..e1440927052d 100644 --- a/pkg/component/worker/kernelsetup_linux.go +++ b/pkg/component/worker/kernelsetup_linux.go @@ -43,9 +43,9 @@ func hasFilesystem(filesystem string) bool { } func modprobe(module string) { - err := exec.Command("modprobe", module) + out, err := exec.Command("modprobe", module).CombinedOutput() if err != nil { - logrus.Warnf("failed to load %s kernel module: %s", module, err) + logrus.Warnf("failed to load %s kernel module: %s, out=%q", module, err.Error(), string(out)) } } From 270df9e1904e2766dfaab3ead6a8f943ad9cce2f Mon Sep 17 00:00:00 2001 From: Ethan Mosbaugh Date: Thu, 13 Feb 2025 07:14:46 -0800 Subject: [PATCH 2/2] fix log format string Co-authored-by: Tom Wieczorek Signed-off-by: Ethan Mosbaugh Signed-off-by: Ethan Mosbaugh (cherry picked from commit 642b0557f741c29db5b2e48ab58a034e68a8cdb2) --- pkg/component/worker/kernelsetup_linux.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/component/worker/kernelsetup_linux.go b/pkg/component/worker/kernelsetup_linux.go index e1440927052d..e9d796d65c80 100644 --- a/pkg/component/worker/kernelsetup_linux.go +++ b/pkg/component/worker/kernelsetup_linux.go @@ -45,7 +45,7 @@ func hasFilesystem(filesystem string) bool { func modprobe(module string) { out, err := exec.Command("modprobe", module).CombinedOutput() if err != nil { - logrus.Warnf("failed to load %s kernel module: %s, out=%q", module, err.Error(), string(out)) + logrus.WithError(err).Warnf("failed to load kernel module %s: %s", module, out) } }