Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admission controller for configuration validation #723

Closed
makhov opened this issue Sep 12, 2024 · 3 comments
Closed

Admission controller for configuration validation #723

makhov opened this issue Sep 12, 2024 · 3 comments
Assignees
@makhov
Labels
keep Exempts issues and pull requests from stale workflow
Milestone
1.5

Comments

@makhov
Copy link
Contributor

makhov commented Sep 12, 2024 •
edited
Loading

We are thinking about having an admission controller or CEL validation. In this issue, we are collecting a list of things that we should be validating:

  • don't allow to create k0s clusters in --single mode and with updateStrategy=Recreate
  • ensure kubernetes skew policy is respected
  • …
@apedriza
Copy link
Contributor

  • CRDs validations on references to other resources within the CRD (ObjectRef exists etc...). In this way we can lighten the controller processing and help in the debugging for the user. For example: do not allow to create a JoinTokenRequest referencing a non-existent Cluster.

@jnummelin jnummelin added this to the 1.3 milestone Nov 7, 2024
@makhov makhov self-assigned this Nov 11, 2024
@makhov makhov modified the milestones: 1.3, 1.4 Dec 13, 2024
@github-actions GitHub Actions
Copy link

The issue is marked as stale since no activity has been recorded in 30 days

@github-actions github-actions bot added the Stale label Jan 30, 2025
@jnummelin jnummelin modified the milestones: 1.4, 1.5 Feb 4, 2025
@github-actions github-actions bot removed the Stale label Feb 6, 2025
@apedriza apedriza added the keep Exempts issues and pull requests from stale workflow label Feb 25, 2025
@makhov
Copy link
Contributor Author

makhov commented Mar 20, 2025

Done in #807

@makhov makhov closed this as completed Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@makhov makhov

Labels
keep Exempts issues and pull requests from stale workflow
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
3 participants
@makhov @jnummelin @apedriza