BytesStripRight and BytesTerminate: can return original array

Author: arekbulski

KaitaiStream.cs

@@ -461,22 +461,29 @@ public byte[] EnsureFixedContents(byte[] expected)
 
         /// <summary>
         /// Perform right-to-left strip on a byte array.
+        /// WARNING: Can return original byte array.
         /// </summary>
         /// <param name="src">The data, as byte array</param>
         /// <param name="padByte">The padding byte, as integer</param>
         public static byte[] BytesStripRight(byte[] src, byte padByte)
         {
             int newLen = src.Length;
+            int maxLen = src.Length;
+
             while (newLen > 0 && src[newLen - 1] == padByte)
                 newLen--;
 
+            if (newLen == maxLen)
+                return src;
+
             byte[] dst = new byte[newLen];
             Array.Copy(src, dst, newLen);
             return dst;
         }
 
         /// <summary>
         /// Perform left-to-right search of specified terminating byte, and cutoff remaining bytes.
+        /// WARNING: Can return original byte array.
         /// </summary>
         /// <param name="src">The data, as byte array</param>
         /// <param name="terminator">The terminating byte, as integer</param>
@@ -492,6 +499,9 @@ public static byte[] BytesTerminate(byte[] src, byte terminator, bool includeTer
             if (includeTerminator && newLen < maxLen)
                 newLen++;
 
+            if (newLen == maxLen)
+                return src;
+
             byte[] dst = new byte[newLen];
             Array.Copy(src, dst, newLen);
             return dst;