Merge pull request #289 from kalamdb/hotfixes/manifest

Fixes to building packages

Author: jamals86

.github/workflows/ci.yml

@@ -15,6 +15,7 @@ env:
   RUST_VERSION: "1.92.0"
   RUSTC_WRAPPER: ""
   CARGO_BUILD_RUSTC_WRAPPER: ""
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   fmt:

.github/workflows/cli-cluster-e2e.yml

@@ -11,15 +11,6 @@ on:
       - 'versions.json'
       - 'nextest.toml'
       - '.github/workflows/cli-cluster-e2e.yml'
-  pull_request:
-    paths:
-      - 'cli/**'
-      - 'scripts/cluster.sh'
-      - 'scripts/download-release-server.sh'
-      - 'scripts/resolve-latest-release-asset.py'
-      - 'versions.json'
-      - 'nextest.toml'
-      - '.github/workflows/cli-cluster-e2e.yml'
   workflow_dispatch:
 
 permissions:
@@ -30,6 +21,7 @@ env:
   RUST_VERSION: "1.92.0"
   RUSTC_WRAPPER: ""
   CARGO_BUILD_RUSTC_WRAPPER: ""
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   resolve_versions:

.github/workflows/codeql.yml

@@ -12,8 +12,12 @@
 name: "CodeQL Advanced"
 
 on:
-  schedule:
-    - cron: '18 9 * * 0'
+  push:
+    branches: [main]
+  workflow_dispatch:
+
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   analyze:

.github/workflows/dart-sdk.yml

@@ -37,6 +37,7 @@ env:
   RUST_VERSION: "1.92.0"
   RUSTC_WRAPPER: ""
   CARGO_BUILD_RUSTC_WRAPPER: ""
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   resolve_versions:

.github/workflows/python-sdk.yml

@@ -25,6 +25,7 @@ on:
 
 env:
   CARGO_TERM_COLOR: always
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   test:

.github/workflows/react-e2e.yml

@@ -1,25 +1,6 @@
 name: React SDK e2e
 
 on:
-  push:
-    branches: [main]
-    paths:
-      - 'link/sdks/typescript/react/**'
-      - 'link/sdks/typescript/client/**'
-      - 'link/sdks/typescript/orm/**'
-      - 'link/link-common/**'
-      - 'link/kalam-client/**'
-      - 'link/kalam-consumer-wasm/**'
-      - '.github/workflows/react-e2e.yml'
-  pull_request:
-    paths:
-      - 'link/sdks/typescript/react/**'
-      - 'link/sdks/typescript/client/**'
-      - 'link/sdks/typescript/orm/**'
-      - 'link/link-common/**'
-      - 'link/kalam-client/**'
-      - 'link/kalam-consumer-wasm/**'
-      - '.github/workflows/react-e2e.yml'
   workflow_dispatch: {}
 
 permissions:
@@ -30,6 +11,7 @@ env:
   RUST_VERSION: "1.92.0"
   WASM_PACK_VERSION: "0.15.0"
   KALAMDB_URL: "http://127.0.0.1:2900"
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   e2e:
@@ -55,7 +37,7 @@ jobs:
           python-version: '3.11'
 
       - name: Setup Node
-        uses: actions/setup-node@v5
+        uses: actions/setup-node@v6
         with:
           node-version: '24'
 

.github/workflows/release.yml

@@ -50,6 +50,7 @@ env:
   DEFAULT_PLATFORMS: "linux-x86_64,macos-aarch64,linux-aarch64"
   RUSTC_WRAPPER: ""
   CARGO_BUILD_RUSTC_WRAPPER: ""
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   sync_versions_manifest:

.github/workflows/typescript-sdk.yml

@@ -61,6 +61,7 @@ env:
   WASM_PACK_VERSION: "0.15.0"
   RUSTC_WRAPPER: ""
   CARGO_BUILD_RUSTC_WRAPPER: ""
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
 
 jobs:
   resolve_versions:
@@ -69,6 +70,7 @@ jobs:
     outputs:
       root_version: ${{ steps.versions.outputs.root_version }}
       typescript_version: ${{ steps.versions.outputs.typescript_version }}
+      test_matrix: ${{ steps.test_matrix.outputs.test_matrix }}
       latest_server_release_tag: ${{ steps.latest_server.outputs.release_tag }}
       selected_server_version: ${{ steps.latest_server.outputs.selected_version }}
       selected_server_selection_reason: ${{ steps.latest_server.outputs.selection_reason }}
@@ -96,6 +98,17 @@ jobs:
           set -euo pipefail
           python3 scripts/versions.py github-outputs --github-output "$GITHUB_OUTPUT" --repository "$GITHUB_REPOSITORY"
 
+      - name: Select TypeScript SDK test matrix
+        id: test_matrix
+        shell: bash
+        run: |
+          set -euo pipefail
+          if [[ "$GITHUB_EVENT_NAME" == "push" ]]; then
+            echo 'test_matrix={"package":["client","consumer","orm"]}' >> "$GITHUB_OUTPUT"
+          else
+            echo 'test_matrix={"package":["client","consumer","orm","react"]}' >> "$GITHUB_OUTPUT"
+          fi
+
       - name: Resolve latest released server asset
         id: latest_server
         shell: bash
@@ -145,8 +158,7 @@ jobs:
       - download_release_server_binary
     strategy:
       fail-fast: false
-      matrix:
-        package: [client, consumer, orm, react]
+      matrix: ${{ fromJSON(needs.resolve_versions.outputs.test_matrix) }}
     steps:
       - name: Checkout
         uses: actions/checkout@v6
@@ -256,7 +268,9 @@ jobs:
   summarize_tests:
     name: Summarize TypeScript SDK Tests
     runs-on: ubuntu-latest
-    needs: test_packages
+    needs:
+      - resolve_versions
+      - test_packages
     if: ${{ always() && needs.test_packages.result != 'cancelled' }}
     outputs:
       total: ${{ steps.parse_badge.outputs.total }}
@@ -276,16 +290,18 @@ jobs:
         id: parse_badge
         shell: bash
         env:
+          EXPECTED_PACKAGES_JSON: ${{ needs.resolve_versions.outputs.test_matrix }}
           JOB_RESULT: ${{ needs.test_packages.result }}
         run: |
           set -euo pipefail
           python3 <<'PYTHON'
+          import json
           import os
           import re
           from pathlib import Path
 
           artifacts_dir = Path("ts-sdk-test-artifacts")
-          expected_packages = {"client", "consumer", "orm", "react"}
+          expected_packages = set(json.loads(os.environ["EXPECTED_PACKAGES_JSON"]).get("package", []))
           found_packages = set()
           total = 0
           passed = 0

.github/workflows/versions.yml

@@ -25,6 +25,9 @@ on:
 permissions:
   contents: read
 
+env:
+  FORCE_JAVASCRIPT_ACTIONS_TO_NODE24: "true"
+
 jobs:
   verify:
     name: Verify versions.json

link/sdks/typescript/consumer/publish.sh

@@ -23,6 +23,8 @@ PUBLISH_REGISTRY_HOST="${PUBLISH_REGISTRY_URL#https://}"
 PUBLISH_REGISTRY_HOST="${PUBLISH_REGISTRY_HOST#http://}"
 PUBLISH_REGISTRY_HOST="${PUBLISH_REGISTRY_HOST%/}"
 BUILD_REGISTRY_URL="${BUILD_REGISTRY_URL:-https://registry.npmjs.org}"
+PUBLISH_DEPENDENCY_WAIT_ATTEMPTS="${PUBLISH_DEPENDENCY_WAIT_ATTEMPTS:-15}"
+PUBLISH_DEPENDENCY_WAIT_SECONDS="${PUBLISH_DEPENDENCY_WAIT_SECONDS:-4}"
 REGISTRY_FLAG="--registry $PUBLISH_REGISTRY_URL"
 ACCESS_FLAG=""
 if [[ -n "$PUBLISH_ACCESS" ]]; then
@@ -134,12 +136,7 @@ PACKAGE_PAGE_URL=""
 if [[ "$PUBLISH_REGISTRY_URL" == "https://registry.npmjs.org" ]]; then
   PACKAGE_PAGE_URL="https://www.npmjs.com/package/${PACKAGE_NAME}"
 fi
-CLIENT_PACKAGE_NAME="$(node -p "Object.keys(JSON.parse(require('fs').readFileSync(process.argv[1], 'utf8')).peerDependencies ?? {}).find((name) => name.endsWith('/client')) || ''" "$PUBLISH_PACKAGE_JSON")"
-if [[ -z "$CLIENT_PACKAGE_NAME" ]]; then
-  echo "❌ Could not determine the required app-facing client package from peerDependencies."
-  exit 1
-fi
-CLIENT_REGISTRY_URL="${PUBLISH_REGISTRY_URL}/${CLIENT_PACKAGE_NAME}"
+INTERNAL_PEER_DEPENDENCIES="$(node -p "const pkg=JSON.parse(require('fs').readFileSync(process.argv[1], 'utf8')); const packageName=process.argv[2]; const scope = packageName.startsWith('@') ? packageName.split('/')[0] : ''; console.log(Object.keys(pkg.peerDependencies ?? {}).filter((name) => scope && name.startsWith(scope + '/') && name !== packageName).join('\n'))" "$PUBLISH_PACKAGE_JSON" "$PACKAGE_NAME")"
 
 echo ""
 echo "══════════════════════════════════════════════════════"
@@ -153,6 +150,37 @@ echo ""
 
 cd "$PUBLISH_DIR"
 
+ensure_registry_auth_configured() {
+  if [[ -n "${NODE_AUTH_TOKEN:-}" ]]; then
+    LOCAL_NPMRC="$PUBLISH_DIR/.npmrc"
+    npm config set "//${PUBLISH_REGISTRY_HOST}/:_authToken" "${NODE_AUTH_TOKEN}" --location=project
+  fi
+}
+
+wait_for_dependency_version() {
+  local dependency_name="$1"
+  local dependency_registry_url="${PUBLISH_REGISTRY_URL}/${dependency_name}"
+  local attempt
+
+  for ((attempt=1; attempt<=PUBLISH_DEPENDENCY_WAIT_ATTEMPTS; attempt++)); do
+    if npm view "$dependency_name@$VERSION" version --silent $REGISTRY_FLAG >/dev/null 2>&1; then
+      echo "✅ Internal dependency ${dependency_name}@$VERSION is available on $PUBLISH_REGISTRY_NAME."
+      return 0
+    fi
+
+    if [[ "$attempt" -lt "$PUBLISH_DEPENDENCY_WAIT_ATTEMPTS" ]]; then
+      echo "⏳ Waiting for ${dependency_name}@$VERSION to appear on $PUBLISH_REGISTRY_NAME (${attempt}/${PUBLISH_DEPENDENCY_WAIT_ATTEMPTS})..."
+      sleep "$PUBLISH_DEPENDENCY_WAIT_SECONDS"
+    fi
+  done
+
+  echo "❌ ${dependency_name}@$VERSION is not published yet on $PUBLISH_REGISTRY_NAME. Publish it first."
+  echo "   registry API: $dependency_registry_url"
+  exit 1
+}
+
+ensure_registry_auth_configured
+
 NPM_TAG_FLAG="--tag latest"
 PRERELEASE_TAG=""
 if [[ "$VERSION" == *"-"* ]]; then
@@ -162,10 +190,11 @@ if [[ "$VERSION" == *"-"* ]]; then
   echo "🏷️  Pre-release version detected — publishing to latest and adding dist-tag: $PRERELEASE_TAG"
 fi
 
-if ! npm view "$CLIENT_PACKAGE_NAME@$VERSION" version --silent $REGISTRY_FLAG >/dev/null 2>&1; then
-  echo "❌ ${CLIENT_PACKAGE_NAME}@$VERSION is not published yet on $PUBLISH_REGISTRY_NAME. Publish the main package first."
-  echo "   registry API: $CLIENT_REGISTRY_URL"
-  exit 1
+if [[ -n "$INTERNAL_PEER_DEPENDENCIES" ]]; then
+  while IFS= read -r dependency_name; do
+    [[ -z "$dependency_name" ]] && continue
+    wait_for_dependency_version "$dependency_name"
+  done <<< "$INTERNAL_PEER_DEPENDENCIES"
 fi
 
 if [[ "$DRY_RUN" == "true" ]]; then
@@ -188,8 +217,7 @@ if [[ -z "${NODE_AUTH_TOKEN:-}" ]]; then
   exit 1
 fi
 
-LOCAL_NPMRC="$PUBLISH_DIR/.npmrc"
-npm config set "//${PUBLISH_REGISTRY_HOST}/:_authToken" "${NODE_AUTH_TOKEN}" --location=project
+ensure_registry_auth_configured
 
 echo ""
 echo "🚀 Publishing $PACKAGE_NAME@$VERSION to $PUBLISH_REGISTRY_NAME..."