finally fixed footer icons

karolt2025 · karolt2025 · commit 41b541d3177a · 2025-06-21T11:36:43.000+08:00
diff --git a/index.html b/index.html
@@ -16,8 +16,8 @@
         <h1>TRAV</h1> <!-- add image here -->
         <nav>
             <ul>
-                <li><a href="#">About</a></li>
-                <li><a href="#">Contact</a></li>
+                <li><a href="https://karolt2025.github.io/secondpage.html">About</a></li>
+                <li><a href="https://karolt2025.github.io/secondpage.html">Contact</a></li>
             </ul>
         </nav>
     </header>
@@ -58,17 +58,12 @@ <h3>
             <div class="logo_box"><img src="images/Letter_T.png" alt="letter T photo"></div>
             <nav class="links_box">
                 <ul>
-                    <li><a href=<i
-                            class="fa-brands fa-linkedin"></i><!-- http://linkedin.com/in/karol-travino <img class="icon" src="img/instagram.svg" alt="LinkedIn">--></a>
-                    </li>
-                    <li><a href="https://github.com/karolt2025"><span>karolt2025</span></a></li>
-                    <!-- <img class="icon" src="images/github.svg" alt="Github">--></a></li>
+                    <li><a href="http://linkedin.com/in/karol-travino"<i class="fa-brands fa-linkedin" alt="LinkedIn logo"></i></a></li>
+                    <li><a href="https://github.com/karolt2025/"<i class="fa-brands fa-square-github" alt="Github logo"></i></a></li>
+                    <li><a href="#">Contact</a></li>
                 </ul>
-                <li><a href="#">Contact</a></li>
-                <li><a><i><span>text</span></i></a></li>
             </nav>
         </section>
-
     </footer>
 
 
diff --git a/secondpage.html b/secondpage.html
@@ -1,39 +1,38 @@
- <!DOCTYPE html>
- <html lang="en">
+<!DOCTYPE html>
+<html lang="en">
 
- <head>
+<head>
     <meta charset="UTF-8">
     <meta http-equiv="X-UA-Compatible" content="IE=edge">
     <meta name="viewport" content="width=device-width, initial-scale=1.0">
     <title>Trav</title>
     <link rel="stylesheet" href="style.css">
     <link href="https://cdnjs.cloudflare.com/ajax/libs/font-awesome/6.7.2/css/all.min.css" rel="stylesheet">
     <link href="https://fonts.googleapis.com/icon?family=Material+Icons" rel="stylesheet">
- </head>
+</head>
 
- <body>
+<body>
     <header>
-    <h1>TRAV</h1> <!-- add image here -->
-    <nav>
-        <ul>
-            <li><a href="#">About</a></li>
-            <li><a href="#">Contact</a></li>
-        </ul>
-    </nav>
-    </header>
-
- <footer>
-        <nav> 
-            <div class="footer box"><img src="images/Letter_T.png" alt="letter T photo">
+        <h1>TRAV</h1> <!-- add image here -->
+        <nav>
             <ul>
-                <li><a href=<i class="fa-brands fa-linkedin"></i><!-- http://linkedin.com/in/karol-travino <img class="icon" src="img/instagram.svg" alt="LinkedIn">--></a></li>
-                <li><a href="https://github.com/karolt2025"><span>karolt2025</span></a></li><!-- <img class="icon" src="images/github.svg" alt="Github">--></a></li>
+                <li><a href="#">About</a></li>
+                <li><a href="#">Contact</a></li>
             </ul>
-            <li><a href="#">Contact</a></li>
-            <li><a><i><span>text</span></i></a></li>
-            </div>
         </nav>
+    </header>
 
-    </footer>   
+    <footer>
+        <section class="footer">
+            <div class="logo_box"><img src="images/Letter_T.png" alt="letter T photo"></div>
+            <nav class="links_box">
+                <ul>
+                    <li><a href="http://linkedin.com/in/karol-travino"<i class="fa-brands fa-linkedin" alt="LinkedIn logo"></i></a></li>
+                    <li><a href="https://github.com/karolt2025/"<i class="fa-brands fa-square-github" alt="Github logo"></i></a></li>
+                    <li><a href="#">Contact</a></li>
+                </ul>
+            </nav>
+        </section>
+    </footer>
 
 </body>
