Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Adding Specific Wells to GGMN (New Zealand Case) #758

Open
EliVolsch opened this issue Jan 14, 2025 · 15 comments
Open

Issue with Adding Specific Wells to GGMN (New Zealand Case) #758

EliVolsch opened this issue Jan 14, 2025 · 15 comments
Assignees
Labels
Priority Item This item is urgent and important should be prioritized Priority: Medium Size: 1 It’s quick, I will have it done in less than 1 hour Support Portal Ticket logged via Kartoza support portal

Comments

@EliVolsch
Copy link
Collaborator

Hi,
I have attached a screenshot for a report that I got when uploading data to the GGMN. as you can see the problem is 'get() returned more than one Well -- it returned 2!'
However, the red rows highlighted in red have ID: 5005 5006 5007, and 5023; and there is no duplicates in the column.
Can you fix this so these 4 wells are also added?
Thank you

Screenshot

@EliVolsch EliVolsch added Priority: Medium Support Portal Ticket logged via Kartoza support portal labels Jan 14, 2025
@meomancer meomancer moved this from To do to This Sprint in IGRAC GGIS Jan 17, 2025
@meomancer meomancer added the Size: 1 It’s quick, I will have it done in less than 1 hour label Jan 17, 2025
@meomancer
Copy link
Collaborator

meomancer commented Jan 18, 2025

Hi @clau1313 @Elie114
The problem is because There is actually 2 wells with ID 5005
https://ggis.un-igrac.org/groundwater/record/410267/ : WWD32
https://ggis.un-igrac.org/groundwater/record/82333/ : Well..5005 Waipukurau Depot

We can check by ID and name

But the problem will be on the monitoring data, which is currently we check the data based on just the ID column

What do you suggest?
Should we:

  • Remove one of it?
  • Also add name on the monitoring data excel to prevent this?

@meomancer meomancer moved this from This Sprint to Blocked or More Information in IGRAC GGIS Jan 18, 2025
@meomancer meomancer moved this from Blocked or More Information to In progress in IGRAC GGIS Jan 20, 2025
@meomancer meomancer moved this from In progress to In Review in IGRAC GGIS Jan 20, 2025
@clau1313
Copy link
Contributor

hi @meomancer, thanks. It would be good to add the name on the monitoring data excel to prevent this issue.

But then, what happens if a well has only ID but no name?

@meomancer
Copy link
Collaborator

Hi @clau1313
The name is just used for checking the well if it returns 2 or more well
If it return more well, it will check also the name

If it is provide no name, if the ID also in multiple wells, it still error

@clau1313
Copy link
Contributor

Hi @meomancer, thanks for the clarification. Then let's use the name for cheking the wells if the system returns 2 or more wells with only ID.

In the case that the ID and name are the same, can the system also check the coordinates? (this scenario is unlikely, but just in case?)

@meomancer meomancer moved this from In Review to This Sprint in IGRAC GGIS Jan 24, 2025
@meomancer
Copy link
Collaborator

Ok @clau1313
I think instead adding the name, we can put latitude and longitude on the files

@Elie114
Copy link
Collaborator

Elie114 commented Jan 24, 2025

Hi @meomancer
Let's go ahead and stick with the ID and Name for now as @clau1313 mentioned.

@Elie114
Copy link
Collaborator

Elie114 commented Feb 10, 2025

how do we follow up from here ? Can you add these 4 wells that we had an issue with ?

@EliVolsch EliVolsch added the Priority Item This item is urgent and important should be prioritized label Feb 11, 2025
@meomancer meomancer moved this from This Sprint to To do in IGRAC GGIS Feb 11, 2025
@meomancer meomancer moved this from To do to This Sprint in IGRAC GGIS Feb 11, 2025
@meomancer
Copy link
Collaborator

meomancer commented Feb 14, 2025

Hi @Elie114 @clau1313
This is quite a big changes as we need to create new column to

  • the uploader excel
  • to the download file
  • update code

It will take time for me to update (about 1 day) as well as re-cache the download file
I will work on it next week

Meanwhile, i have other solution
I think we just need to upload the monitoring data?
We can change the duplicated original_id for now, and after monitoring_data has been uploaded, we can revert it
What do you think?

@Elie114
Copy link
Collaborator

Elie114 commented Feb 14, 2025

Okay, let's do this for now.

Can you please just explain why it is a big change I thought we are just checking in case of duplicated IDS, the code will check the name too; why do we need to change the format of the uploader and download file? Because we don't want to make things more complicated.

Ok @clau1313 I think instead adding the name, we can put latitude and longitude on the files

Does this make it easier or same steps too ?

@meomancer
Copy link
Collaborator

Can you please just explain why it is a big change I thought we are just checking in case of duplicated IDS, the code will check the name too; why do we need to change the format of the uploader and download file? Because we don't want to make things more complicated.

Hi @Elie114
It is not for the "Well uploader" excel, but for the monitoring data
As monitoring data does not have name column on it

So to make use of name, we need to:

  1. Add name column for all excel for upload (now it is just on well upload)
  2. Adding it also for the download file (the cache), to make it consistence

@meomancer meomancer moved this from This Sprint to In progress in IGRAC GGIS Feb 21, 2025
@meomancer
Copy link
Collaborator

Hi @Elie114
I have changed the duplicated original id for now, could you retry upload the data?
After that, please ping me so i can rechange the id

@meomancer meomancer moved this from In progress to In Review in IGRAC GGIS Feb 21, 2025
@meomancer meomancer moved this from In Review to In progress in IGRAC GGIS Feb 21, 2025
@Elie114
Copy link
Collaborator

Elie114 commented Feb 21, 2025

Can you please just explain why it is a big change I thought we are just checking in case of duplicated IDS, the code will check the name too; why do we need to change the format of the uploader and download file? Because we don't want to make things more complicated.

Hi @Elie114 It is not for the "Well uploader" excel, but for the monitoring data As monitoring data does not have name column on it

So to make use of name, we need to:

  1. Add name column for all excel for upload (now it is just on well upload)
  2. Adding it also for the download file (the cache), to make it consistence

@clau1313 Please check this

@Elie114
Copy link
Collaborator

Elie114 commented Feb 21, 2025

Hi @Elie114 I have changed the duplicated original id for now, could you retry upload the data? After that, please ping me so i can rechange the id

This is Done !

@Elie114
Copy link
Collaborator

Elie114 commented Feb 21, 2025 via email

@Elie114
Copy link
Collaborator

Elie114 commented Feb 22, 2025 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority Item This item is urgent and important should be prioritized Priority: Medium Size: 1 It’s quick, I will have it done in less than 1 hour Support Portal Ticket logged via Kartoza support portal
Projects
Status: In progress
Development

No branches or pull requests

4 participants