Skip to content

Commit c20b45a

Browse files
committed
use native python for config validation instead of docker
1 parent 9ae05a7 commit c20b45a

1 file changed

Lines changed: 17 additions & 5 deletions

File tree

config/validate_plano_config.sh

Lines changed: 17 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,32 @@
11
#!/bin/bash
22

3+
SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
34
failed_files=()
45

56
for file in $(find . -name config.yaml -o -name plano_config_full_reference.yaml); do
67
echo "Validating ${file}..."
7-
touch $(pwd)/${file}_rendered
8-
if ! docker run --rm -v "$(pwd)/${file}:/app/plano_config.yaml:ro" -v "$(pwd)/${file}_rendered:/app/plano_config_rendered.yaml:rw" --entrypoint /bin/sh ${PLANO_DOCKER_IMAGE:-katanemo/plano:0.4.9} -c "python -m planoai.config_generator" 2>&1 > /dev/null ; then
8+
rendered_file="$(pwd)/${file}_rendered"
9+
touch "$rendered_file"
10+
11+
PLANO_CONFIG_FILE="$(pwd)/${file}" \
12+
PLANO_CONFIG_SCHEMA_FILE="${SCRIPT_DIR}/plano_config_schema.yaml" \
13+
TEMPLATE_ROOT="${SCRIPT_DIR}" \
14+
ENVOY_CONFIG_TEMPLATE_FILE="envoy.template.yaml" \
15+
PLANO_CONFIG_FILE_RENDERED="$rendered_file" \
16+
ENVOY_CONFIG_FILE_RENDERED="/dev/null" \
17+
python -m planoai.config_generator 2>&1 > /dev/null
18+
19+
if [ $? -ne 0 ]; then
920
echo "Validation failed for $file"
1021
failed_files+=("$file")
1122
fi
23+
1224
RENDERED_CHECKED_IN_FILE=$(echo $file | sed 's/\.yaml$/_rendered.yaml/')
1325
if [ -f "$RENDERED_CHECKED_IN_FILE" ]; then
1426
echo "Checking rendered file against checked-in version..."
15-
if ! diff -q "${file}_rendered" "$RENDERED_CHECKED_IN_FILE" > /dev/null; then
16-
echo "Rendered file ${file}_rendered does not match checked-in version ${RENDERED_CHECKED_IN_FILE}"
17-
failed_files+=("${file}_rendered")
27+
if ! diff -q "$rendered_file" "$RENDERED_CHECKED_IN_FILE" > /dev/null; then
28+
echo "Rendered file $rendered_file does not match checked-in version ${RENDERED_CHECKED_IN_FILE}"
29+
failed_files+=("$rendered_file")
1830
else
1931
echo "Rendered file matches checked-in version."
2032
fi

0 commit comments

Comments
 (0)