diff --git a/studio/flight-delay-analysis/notebooks/load_data.py b/studio/flight-delay-analysis/notebooks/load_data.py index aab753d..d07ef8b 100644 --- a/studio/flight-delay-analysis/notebooks/load_data.py +++ b/studio/flight-delay-analysis/notebooks/load_data.py @@ -44,7 +44,26 @@ def download_from_public_url(url): if r.headers['content-type'] in ['application/x-tar', 'application/x-gzip']: print('Extracting downloaded file in directory "{}" ...'.format(data_dir)) with tarfile.open(downloaded_data_file, 'r') as tar: - tar.extractall(data_dir) + def is_within_directory(directory, target): + + abs_directory = os.path.abspath(directory) + abs_target = os.path.abspath(target) + + prefix = os.path.commonprefix([abs_directory, abs_target]) + + return prefix == abs_directory + + def safe_extract(tar, path=".", members=None, *, numeric_owner=False): + + for member in tar.getmembers(): + member_path = os.path.join(path, member.name) + if not is_within_directory(path, member_path): + raise Exception("Attempted Path Traversal in Tar File") + + tar.extractall(path, members, numeric_owner=numeric_owner) + + + safe_extract(tar, data_dir) print('Removing downloaded file ...') downloaded_data_file.unlink()