Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate simple harmonic oscillator from the damped oscillators #34

Closed
cmp0xff opened this issue Mar 23, 2024 · 2 comments · Fixed by #48
Closed

Separate simple harmonic oscillator from the damped oscillators #34

cmp0xff opened this issue Mar 23, 2024 · 2 comments · Fixed by #48
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request model Change of models

Comments

@cmp0xff
Copy link
Collaborator

cmp0xff commented Mar 23, 2024

A simple harmonic oscillator, without damping, can be described by the Lagrangian action
$$S_L[x] = \int_{t_0}^{t_1} \mathbb{d}t \left\{\frac{1}{2} m \dot x^2 - \frac{1}{2} m \omega x^2 \right\}\,.$$
This action is so important that I think it makes sense to single out the simple harmonic oscillator.

I also propose to have damped oscillators as a generalisation (mathematical-physically), or a subclass, of simple harmonic oscillators.

@cmp0xff cmp0xff added documentation Improvements or additions to documentation enhancement New feature or request model Change of models labels Mar 23, 2024
@cmp0xff
Copy link
Collaborator Author

cmp0xff commented Mar 23, 2024

This separation also enables #10. With damping, I don't know how to start a Hamiltonian description..

@emptymalei
Copy link
Member

Makes sense. I can work on this.

@emptymalei emptymalei self-assigned this Mar 29, 2024
emptymalei added a commit that referenced this issue Apr 16, 2024
…d HO (#48)

* refactor(harmonic-oscillator): sparate the class of simple and damped oscillator

#34

* docs(harmonic-oscillator): reduce the docstrings of harmonic oscillators

* fix(harmonic-oscillator): remove unused code in harmonic oscillator

#34

* refactor(harmonic-oscillator): change type hint for type float or ndarray

#34

* fix(harmonic-oscillator): use ArrayLike instead of union of float and ndarray

#34

* fix(harmonic-oscillator): add initial phase to harmonic oscillator (simple)

#34

* docs(harmonic-oscillator): adjust tutorials to include ations or equation of motion

#49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request model Change of models
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants