Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reuse the class HarmonicOscillatorSystem to support complex cases. #61

Closed
cmp0xff opened this issue Jul 23, 2024 · 0 comments · Fixed by #62
Closed

Reuse the class HarmonicOscillatorSystem to support complex cases. #61

cmp0xff opened this issue Jul 23, 2024 · 0 comments · Fixed by #62
Assignees
@cmp0xff

Comments

@cmp0xff
Copy link
Collaborator

cmp0xff commented Jul 23, 2024 

          Out of curiosity, why not reuse the HarmonicOscillatorSystem class? Seems like you've extend the HarmonicOscillatorSystem to support complex cases.

Originally posted by @GrumpySapiens in #58 (comment)
@cmp0xff cmp0xff self-assigned this Jul 23, 2024
cmp0xff added a commit that referenced this issue Jul 23, 2024
@cmp0xff
feat(comment): #61 #58 (comment)
9cc7384
@cmp0xff cmp0xff linked a pull request Jul 23, 2024 that will close this issue
feat(comment): #61 reuse the class HarmonicOscillatorSystem to support complex cases #62
Merged
cmp0xff added a commit that referenced this issue Jul 23, 2024
@cmp0xff
chore(typo): #61
9defa84
cmp0xff added a commit that referenced this issue Jul 23, 2024
@cmp0xff
feat(comment): #61 reuse the class HarmonicOscillatorSystem to suppor…
1347914 
…t complex cases (#62)

* feat(comment): #61 #58 (comment)

* feat: #59 improve exception messages

* chore(typo): #61
cmp0xff added a commit that referenced this issue Jul 24, 2024
@cmp0xff
feat(comment): #61 reuse the class HarmonicOscillatorSystem to suppor…
87d8d3a 
…t complex cases (#62)

* feat(comment): #61 #58 (comment)

* feat: #59 improve exception messages

* chore(typo): #61
cmp0xff added a commit that referenced this issue Aug 4, 2024
@cmp0xff @emptymalei
feat(model): #36 one dimensional harmonic oscillator chain (#58)
baf2779 
* feat: #36 work in progress

* fix: #36 frequency and fourier

* feat: #36 Use axis instead of transpose

* feat: #36 add 0-dimensional complex harmonic oscillator

* fix: #36 1-dimensional harmonic oscillator circle

* feat: #36 docs, example, etc.

* fix: #36 solution to the travelling waves

* feat(model): #59 make a class for linear motion (#60)

* feat: #59 free particle

* chore(poetry): #59 🔒

* feat(comment): #61 reuse the class HarmonicOscillatorSystem to support complex cases (#62)

* feat(comment): #61 #58 (comment)

* feat: #59 improve exception messages

* chore(typo): #61

* feat(comment): #36 #58 (comment)

* chore(typing): #36

* feat: #63 make real oscillators real again

* feat: #63 make complex oscillators finally complex

* chore: #63 typing, import

* feat(refactor): #63 private communication with @emptymalei

* chore: #63 typing, import

* chore(typing): #63

* feat: #36 migrate to the same place (private communication with @emptymalei)

* feat(pytest): #36

* doc(tutorial): #36 work in progress

* fix: #63 edge cases

* chore: #36 propagate 2718ef8

* chore(typing): #69

* fix(typing): #69

* doc(model): #71 tutorial for the complex oscillator

* chore(poetry): #71 docs versions

* doc(comment): #36 #58 (comment)

* fix: #36 even degrees of freedom

* doc(model): #36 tutorial

* chore(cd): #71 fix NameError: name 'system_specs' is not defined

* fix(comment): #71 @emptymalei #72 (review)

* fix(comment): #36 @emptymalei #72 (review)

* doc(comment): #36 @emptymalei #58 (comment)

Co-authored-by: LM <[email protected]>

* doc(comment): #36 @emptymalei #58 (comment)

Co-authored-by: LM <[email protected]>

* doc(comment): #36 @emptymalei #58 (comment)

* chore(typing): #36 simplify

---------

Co-authored-by: LM <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmp0xff cmp0xff

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@cmp0xff