Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make developer, user and mypy happy with scalar and vector typing #85

Open
cmp0xff opened this issue Aug 19, 2024 · 0 comments
Open

Make developer, user and mypy happy with scalar and vector typing #85

cmp0xff opened this issue Aug 19, 2024 · 0 comments
Assignees
@cmp0xff
Labels
enhancement New feature or request meta

Comments

@cmp0xff
Copy link
Collaborator

cmp0xff commented Aug 19, 2024 •
edited
Loading

  • For developers:
    • Simplify typing sequential arguments. t: Collection[float | int] | npt.NDArray[np.float64] | npt.NDArray[np.int64] | float | int is too much.
    • Ideally no t = np.asarray(t) at the beginning of all functions
  • For users:
    • Allow inserting common scalars and vectors ( list / np.ndarray / tuple / set / ... )
    • If not returning a pd.DataFrame, return a scalar if the input is a scalar
  • For mypy, make it happy
@cmp0xff cmp0xff self-assigned this Aug 19, 2024
@cmp0xff cmp0xff added enhancement New feature or request meta labels Sep 3, 2024
@cmp0xff cmp0xff changed the title Reduce conversion to numpy arrays upon onset with decorators Make developer, user and mypy happy with scalar and vector typing Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cmp0xff cmp0xff

Labels
enhancement New feature or request meta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cmp0xff