Skip to content

Commit 825e9af

Browse files
author
John Doherty
committed
fixed helpers seconds/milliseconds typos
1 parent abef00a commit 825e9af

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "selenium-cucumber-js",
3-
"version": "1.5.4",
3+
"version": "1.5.5",
44
"description": "JavaScript browser automation framework using official selenium-webdriver and cucumber-js",
55
"main": "index.js",
66
"scripts": {

runtime/helpers.js

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module.exports = {
33
/**
44
* returns a promise that is called when the url has loaded and the body element is present
55
* @param {string} url - url to load
6-
* @param {integer} waitInSeconds - number of milliseconds to wait for page to load
6+
* @param {integer} waitInSeconds - number of seconds to wait for page to load
77
* @returns {Promise} resolved when url has loaded otherwise rejects
88
* @example
99
* helpers.loadPage('http://www.google.com');
@@ -136,10 +136,10 @@ module.exports = {
136136
* @example
137137
* helpers.waitUntilAttributeEquals('html', 'data-busy', 'false', 5);
138138
*/
139-
waitUntilAttributeEquals: function(elementSelector, attributeName, attributeValue, waitInSeconds) {
139+
waitUntilAttributeEquals: function(elementSelector, attributeName, attributeValue, waitInMilliseconds) {
140140

141141
// use either passed in timeout or global default
142-
var timeout = (waitInSeconds) ? (waitInSeconds * 1000) : DEFAULT_TIMEOUT;
142+
var timeout = waitInMilliseconds || DEFAULT_TIMEOUT;
143143

144144
// repeatedly execute the test until it's true or we timeout
145145
return driver.wait(function() {

0 commit comments

Comments
 (0)