Revert "make self-desctructing namespaces optional"

This reverts commit ffe3460.

On-behalf-of: SAP <[email protected]>
Signed-off-by: Simon Bein <[email protected]>

Author: SimonTheLeg

test/e2e/frontproxies/frontproxies_test.go

@@ -45,7 +45,7 @@ func TestCreateFrontProxy(t *testing.T) {
 	ctx := context.Background()
 	namespace := "create-frontproxy"
 
-	utils.CreateNamespace(t, ctx, client, namespace, true)
+	utils.CreateSelfDestructingNamespace(t, ctx, client, namespace)
 
 	// deploy rootshard
 	rootShard := utils.DeployRootShard(ctx, t, client, namespace)

test/e2e/rootshards/rootshards_test.go

@@ -41,7 +41,7 @@ func TestCreateRootShard(t *testing.T) {
 	ctx := context.Background()
 	namespace := "create-rootshard"
 
-	utils.CreateNamespace(t, ctx, client, namespace, true)
+	utils.CreateSelfDestructingNamespace(t, ctx, client, namespace)
 	rootShard := utils.DeployRootShard(ctx, t, client, namespace)
 
 	configSecretName := "kubeconfig"

test/e2e/shards/shards_test.go

@@ -44,7 +44,7 @@ func TestCreateShard(t *testing.T) {
 
 	// create namspace
 	namespace := "create-shard"
-	utils.CreateNamespace(t, ctx, client, namespace, true)
+	utils.CreateSelfDestructingNamespace(t, ctx, client, namespace)
 
 	// deploy a root shard incl. etcd
 	rootShard := utils.DeployRootShard(ctx, t, client, namespace)

test/utils/utils.go

@@ -77,7 +77,7 @@ func GetKubeClient(t *testing.T) ctrlruntimeclient.Client {
 	return c
 }
 
-func CreateNamespace(t *testing.T, ctx context.Context, client ctrlruntimeclient.Client, name string, selfDestructing bool) {
+func CreateSelfDestructingNamespace(t *testing.T, ctx context.Context, client ctrlruntimeclient.Client, name string) {
 	t.Helper()
 
 	ns := corev1.Namespace{}
@@ -88,14 +88,12 @@ func CreateNamespace(t *testing.T, ctx context.Context, client ctrlruntimeclient
 		t.Fatal(err)
 	}
 
-	if selfDestructing {
-		t.Cleanup(func() {
-			t.Logf("Deleting namespace %s…", name)
-			if err := client.Delete(ctx, &ns); err != nil {
-				t.Fatal(err)
-			}
-		})
-	}
+	t.Cleanup(func() {
+		t.Logf("Deleting namespace %s…", name)
+		if err := client.Delete(ctx, &ns); err != nil {
+			t.Fatal(err)
+		}
+	})
 }
 
 func SelfDestuctingPortForward(