Skip to content

Commit abad680

Browse files
committed
btrfs-progs: clean up includes
Remove unused includes, add ones that are missing. Signed-off-by: David Sterba <[email protected]>
1 parent 5af36f0 commit abad680

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+44
-84
lines changed

check/mode-original.h

+5
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,11 @@
2121
#ifndef __BTRFS_CHECK_MODE_ORIGINAL_H__
2222
#define __BTRFS_CHECK_MODE_ORIGINAL_H__
2323

24+
#include "kerncompat.h"
25+
#include "kernel-lib/rbtree.h"
26+
#include "kernel-lib/list.h"
27+
#include "kernel-shared/uapi/btrfs_tree.h"
28+
#include "common/extent-cache.h"
2429
#include "common/rbtree-utils.h"
2530

2631
struct extent_backref {

cmds/device.c

-1
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@
2626
#include <dirent.h>
2727
#include <stdbool.h>
2828
#include "kernel-shared/zoned.h"
29-
#include "kernel-shared/volumes.h"
3029
#include "common/string-table.h"
3130
#include "common/utils.h"
3231
#include "common/help.h"

cmds/filesystem-usage.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
#define __CMDS_FI_USAGE_H__
2121

2222
#include "kerncompat.h"
23-
#include "kernel-shared/volumes.h"
23+
#include "kernel-shared/uapi/btrfs.h"
2424
#include "common/array.h"
2525

2626
struct device_info {

cmds/props.h

+2
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@
1717
#ifndef __BTRFS_PROPS_H__
1818
#define __BTRFS_PROPS_H__
1919

20+
#include <stdbool.h>
21+
2022
enum prop_object_type {
2123
prop_object_dev = (1U << 0),
2224
prop_object_root = (1U << 1),

cmds/reflink.c

-2
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
#include <unistd.h>
2424
#include "kernel-lib/list.h"
2525
#include "common/messages.h"
26-
#include "common/open-utils.h"
27-
#include "common/parse-utils.h"
2826
#include "common/string-utils.h"
2927
#include "common/help.h"
3028
#include "cmds/commands.h"

cmds/scrub.c

-2
Original file line numberDiff line numberDiff line change
@@ -50,11 +50,9 @@
5050
#include "common/open-utils.h"
5151
#include "common/units.h"
5252
#include "common/device-utils.h"
53-
#include "common/parse-utils.h"
5453
#include "common/sysfs-utils.h"
5554
#include "common/string-table.h"
5655
#include "common/string-utils.h"
57-
#include "common/parse-utils.h"
5856
#include "common/help.h"
5957
#include "cmds/commands.h"
6058

common/clear-cache.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,9 @@
3131
#include "kernel-shared/file-item.h"
3232
#include "common/internal.h"
3333
#include "common/messages.h"
34+
#include "common/clear-cache.h"
3435
#include "check/repair.h"
3536
#include "check/mode-common.h"
36-
#include "common/clear-cache.h"
3737

3838
/*
3939
* Number of free space cache inodes to delete in one transaction.

common/device-scan.h

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
#include "kerncompat.h"
2121
#include <dirent.h>
22-
#include "kernel-lib/bitops.h"
2322
#include "kernel-shared/uapi/btrfs.h"
2423

2524
enum {

common/device-utils.h

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include "kerncompat.h"
2121
#include <stdbool.h>
2222
#include <unistd.h>
23-
#include "kernel-lib/bitops.h"
2423

2524
struct btrfs_ioctl_dev_info_args;
2625
struct stat;

common/extent-tree-utils.c

-4
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,8 @@
1616

1717
#include "kerncompat.h"
1818
#include <stddef.h>
19-
#include "kernel-shared/accessors.h"
2019
#include "kernel-shared/uapi/btrfs_tree.h"
2120
#include "kernel-shared/ctree.h"
22-
#include "kernel-shared/disk-io.h"
23-
#include "kernel-shared/free-space-tree.h"
24-
#include "kernel-shared/transaction.h"
2521
#include "common/extent-tree-utils.h"
2622

2723
/*

common/extent-tree-utils.h

-2
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@
1818
#define _EXTENT_TREE_UTILS_H_
1919

2020
#include "kerncompat.h"
21-
#include "kernel-lib/bitops.h"
22-
#include "kernel-shared/compression.h"
2321

2422
struct btrfs_inode_item;
2523
struct btrfs_path;

common/fsfeatures.h

+1
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@
2020
#include "kerncompat.h"
2121
#include <stdio.h>
2222
#include "kernel-lib/sizes.h"
23+
#include "kernel-shared/uapi/btrfs.h"
2324

2425
#define BTRFS_MKFS_DEFAULT_NODE_SIZE SZ_16K
2526

common/root-tree-utils.c

+4-2
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,14 @@
1414
* Boston, MA 021110-1307, USA.
1515
*/
1616

17+
#include "kerncompat.h"
1718
#include <time.h>
1819
#include <uuid/uuid.h>
19-
#include "common/root-tree-utils.h"
20-
#include "common/messages.h"
2120
#include "kernel-shared/disk-io.h"
2221
#include "kernel-shared/uuid-tree.h"
22+
#include "kernel-shared/transaction.h"
23+
#include "common/root-tree-utils.h"
24+
#include "common/messages.h"
2325

2426
int btrfs_make_root_dir(struct btrfs_trans_handle *trans,
2527
struct btrfs_root *root, u64 objectid)

common/root-tree-utils.h

+5-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@
1717
#ifndef __ROOT_TREE_UTILS_H__
1818
#define __ROOT_TREE_UTILS_H__
1919

20-
#include "kernel-shared/transaction.h"
20+
#include "kerncompat.h"
21+
22+
struct btrfs_root;
23+
struct btrfs_fs_info;
24+
struct btrfs_trans_handle;
2125

2226
int btrfs_make_root_dir(struct btrfs_trans_handle *trans,
2327
struct btrfs_root *root, u64 objectid);

common/send-stream.c

-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222
#include <stdlib.h>
2323
#include <string.h>
2424
#include <time.h>
25-
#include "kernel-shared/accessors.h"
2625
#include "kernel-shared/uapi/btrfs_tree.h"
2726
#include "kernel-shared/uapi/btrfs.h"
2827
#include "kernel-shared/send.h"

common/send-utils.h

+1
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121

2222
#include "kerncompat.h"
2323
#include <stddef.h>
24+
#include "kernel-shared/uapi/btrfs.h"
2425

2526
enum subvol_search_type {
2627
subvol_search_by_root_id,

common/sysfs-utils.h

+1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
#ifndef __COMMON_SYSFS_UTILS__
1818
#define __COMMON_SYSFS_UTILS__
1919

20+
#include "kerncompat.h"
2021
#include <stddef.h>
2122

2223
int sysfs_open_file(const char *name);

common/tree-search.h

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
#ifndef __COMMON_TREE_SEARCH_H__
22
#define __COMMON_TREE_SEARCH_H__
33

4-
#include "kernel-shared/uapi/btrfs_tree.h"
4+
#include "kerncompat.h"
5+
#include <stdbool.h>
56
#include "kernel-shared/uapi/btrfs.h"
67

78
#define BTRFS_TREE_SEARCH_V2_BUF_SIZE 65536

common/utils.h

-1
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@
2525
#include <sys/stat.h>
2626
#include "kernel-lib/list.h"
2727
#include "kernel-shared/volumes.h"
28-
#include "common/fsfeatures.h"
2928

3029
struct list_head;
3130

convert/common.c

-1
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@
3030
#include "kernel-shared/file-item.h"
3131
#include "kernel-shared/transaction.h"
3232
#include "kernel-shared/free-space-tree.h"
33-
#include "common/path-utils.h"
3433
#include "common/messages.h"
3534
#include "common/string-utils.h"
3635
#include "common/extent-tree-utils.h"

convert/main.c

-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@
111111
#include "common/cpu-utils.h"
112112
#include "common/messages.h"
113113
#include "common/task-utils.h"
114-
#include "common/path-utils.h"
115114
#include "common/help.h"
116115
#include "common/parse-utils.h"
117116
#include "common/string-utils.h"

crypto/blake2b-avx2.c

-1
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515

1616
#include <stddef.h>
1717
#include <stdint.h>
18-
#include <stdlib.h>
1918
#include <string.h>
2019

2120
#include "blake2.h"

crypto/blake2b-ref.c

-2
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,8 @@
1616
#include <stdint.h>
1717
#include <string.h>
1818
#include <stdio.h>
19-
2019
#include "blake2.h"
2120
#include "blake2-impl.h"
22-
2321
#include "common/cpu-utils.h"
2422

2523
static const uint64_t blake2b_IV[8] =

crypto/blake2b-sse2.c

-2
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
*/
1515

1616
#include <stdint.h>
17-
#include <string.h>
18-
1917
#include "blake2.h"
2018
#include "blake2-impl.h"
2119
#include "blake2-config.h"

crypto/blake2b-sse41.c

-3
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,6 @@
1414
*/
1515

1616
#include <stdint.h>
17-
#include <string.h>
18-
#include <stdio.h>
19-
2017
#include "blake2.h"
2118
#include "blake2-impl.h"
2219
#include "blake2-config.h"

crypto/hash-speedtest.c

-3
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,6 @@
2626
#define HAVE_PERF
2727
#endif
2828
#include "crypto/hash.h"
29-
#include "crypto/crc32c.h"
30-
#include "crypto/sha.h"
31-
#include "crypto/blake2.h"
3229
#include "common/messages.h"
3330
#include "common/cpu-utils.h"
3431

crypto/hash-vectest.c

-3
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,6 @@
1616

1717
#include "kerncompat.h"
1818
#include "crypto/hash.h"
19-
#include "crypto/crc32c.h"
20-
#include "crypto/sha.h"
21-
#include "crypto/blake2.h"
2219
#include "common/messages.h"
2320
#include "common/cpu-utils.h"
2421

crypto/hash.c

+1
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
* Boston, MA 021110-1307, USA.
1515
*/
1616

17+
#include "kerncompat.h"
1718
#include "crypto/hash.h"
1819
#include "crypto/crc32c.h"
1920
#include "crypto/xxhash.h"

crypto/sha224-256.c

-1
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@
4242

4343
#include "crypto/sha.h"
4444
#include "crypto/sha-private.h"
45-
4645
#include "common/cpu-utils.h"
4746

4847
/* Define the SHA shift, rotate left, and rotate right macros */

image/metadump.h

-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
#include "kerncompat.h"
2121
#include <pthread.h>
22-
#include "kernel-lib/rbtree.h"
2322
#include "kernel-lib/list.h"
2423
#include "kernel-lib/sizes.h"
2524
#include "kernel-shared/ctree.h"

kernel-lib/bitmap.h

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
#ifndef _BTRFS_PROGS_LINUX_BITMAP_H_
1111
#define _BTRFS_PROGS_LINUX_BITMAP_H_
1212

13-
#include <stdlib.h>
1413
#include "kerncompat.h"
14+
#include <stdlib.h>
1515
#include "kernel-lib/bitops.h"
1616

1717
static inline unsigned long *bitmap_zalloc(unsigned int nbits)

kernel-lib/mktables.c

-3
Original file line numberDiff line numberDiff line change
@@ -22,10 +22,7 @@
2222
*/
2323

2424
#include <stdio.h>
25-
#include <string.h>
2625
#include <inttypes.h>
27-
#include <stdlib.h>
28-
#include <time.h>
2926

3027
static uint8_t gfmul(uint8_t a, uint8_t b)
3128
{

kernel-lib/overflow.h

+2
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,8 @@
33
#define __LINUX_OVERFLOW_H
44

55
#include <stdbool.h>
6+
#include <stddef.h>
7+
#include <stdint.h>
68

79
/*
810
* We need to compute the minimum and maximum values representable in a given

kernel-lib/raid56.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -21,11 +21,11 @@
2121
*
2222
* This file was postprocessed using unroll.pl and then ported to userspace
2323
*/
24+
#include "kerncompat.h"
2425
#include <errno.h>
2526
#include <stdlib.h>
2627
#include <string.h>
2728
#include <stdint.h>
28-
#include "kerncompat.h"
2929
#include "kernel-shared/volumes.h"
3030
#include "kernel-shared/uapi/btrfs_tree.h"
3131
#include "kernel-lib/raid56.h"

kernel-lib/raid56.h

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424

2525
#include "kerncompat.h"
2626
#include <stddef.h>
27-
#include "kernel-lib/bitops.h"
2827

2928
void raid6_gen_syndrome(int disks, size_t bytes, void **ptrs);
3029
int raid5_gen_result(int nr_devs, size_t stripe_len, int dest, void **data);

kernel-lib/trace.h

+2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
#ifndef __PROGS_TRACE_H__
22
#define __PROGS_TRACE_H__
33

4+
#include "kerncompat.h"
5+
46
struct btrfs_work;
57
struct btrfs_fs_info;
68
struct extent_state;

kernel-shared/accessors.h

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
#include "kerncompat.h"
77
#include <stddef.h>
88
#include <string.h>
9-
#include "kernel-lib/bitops.h"
109
#include "kernel-shared/extent_io.h"
1110
#include "kernel-shared/uapi/btrfs.h"
1211
#include "kernel-shared/uapi/btrfs_tree.h"

kernel-shared/async-thread.h

-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include "kerncompat.h"
1111
#include <stdbool.h>
1212
#include "kernel-lib/list.h"
13-
#include "kernel-lib/bitops.h"
1413

1514
struct btrfs_fs_info;
1615
struct btrfs_workqueue;

kernel-shared/backref.c

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#include <stdbool.h>
2121
#include <stdint.h>
2222
#include <string.h>
23-
#include <errno.h>
2423
#include "kernel-lib/list.h"
2524
#include "kernel-shared/accessors.h"
2625
#include "kernel-shared/extent_io.h"

kernel-shared/backref.h

-1
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@
2020
#define __BTRFS_BACKREF_H__
2121

2222
#include "kerncompat.h"
23-
#include "kernel-lib/bitops.h"
2423

2524
struct btrfs_extent_item;
2625
struct btrfs_fs_info;

kernel-shared/ctree.h

-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
#include <stdbool.h>
2424
#include <stddef.h>
2525
#include "kernel-lib/list.h"
26-
#include "kernel-lib/bitops.h"
2726
#include "kernel-lib/rbtree_types.h"
2827
#include "kernel-shared/uapi/btrfs.h"
2928
#include "kernel-shared/uapi/btrfs_tree.h"

kernel-shared/delayed-ref.h

-1
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,6 @@
2424
#include <stdbool.h>
2525
#include "kernel-lib/list.h"
2626
#include "kernel-lib/rbtree_types.h"
27-
#include "kernel-lib/bitops.h"
2827
#include "kernel-shared/ctree.h"
2928
#include "kernel-shared/uapi/btrfs_tree.h"
3029

0 commit comments

Comments
 (0)