Skip to content

Commit b77cdb2

Browse files
committed
btrfs-progs: fix mixup between bitwise and logical operators in print_table_head()
As reported (cppcheck), there's bitwise operator used in place of logical. This will still work but it's a misuse. Issue: #1031 Signed-off-by: David Sterba <[email protected]>
1 parent 8dd63aa commit b77cdb2

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

cmds/qgroup.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -456,8 +456,8 @@ static void print_table_head(void)
456456
max_len = btrfs_qgroup_columns[i].max_len;
457457
if (!btrfs_qgroup_columns[i].need_print)
458458
continue;
459-
if ((i == BTRFS_QGROUP_QGROUPID) | (i == BTRFS_QGROUP_PARENT) |
460-
(i == BTRFS_QGROUP_CHILD))
459+
if ((i == BTRFS_QGROUP_QGROUPID) || (i == BTRFS_QGROUP_PARENT) ||
460+
(i == BTRFS_QGROUP_CHILD))
461461
printf("%-*s", max_len, btrfs_qgroup_columns[i].column_name);
462462
else
463463
printf("%*s", max_len, btrfs_qgroup_columns[i].column_name);
@@ -468,8 +468,8 @@ static void print_table_head(void)
468468
max_len = btrfs_qgroup_columns[i].max_len;
469469
if (!btrfs_qgroup_columns[i].need_print)
470470
continue;
471-
if ((i == BTRFS_QGROUP_QGROUPID) | (i == BTRFS_QGROUP_PARENT) |
472-
(i == BTRFS_QGROUP_CHILD)) {
471+
if ((i == BTRFS_QGROUP_QGROUPID) || (i == BTRFS_QGROUP_PARENT) ||
472+
(i == BTRFS_QGROUP_CHILD)) {
473473
len = strlen(btrfs_qgroup_columns[i].column_name);
474474
while (len--)
475475
printf("-");

0 commit comments

Comments
 (0)