Consider only the desired instances for total Instances #323
Description
upgrade-manager/controllers/upgrade.go
Line 398 in 8e0f67d
totalNodes = len(scalingGroup.Instances)
targets = make([]*autoscaling.Instance, 0)
)
unavailableInt := CalculateMaxUnavailable(batchSize, totalNodes)
If upgrade-manager crashes in between and picks up an existing rolling upgrade CR, there could be replacement instances considered in the len(scalingGroup.Instances). For example, if an ASG has 3 instances and the upgrade-manager crashed after setting all the instances to standBy, when the upgrade-manager next picks the CR, will have the totalNodes as 6 and that is incorrect.