Change lengths to reference in RenderDeprecatedFlexibleBox.cpp

https://bugs.webkit.org/show_bug.cgi?id=277020

Reviewed by Alan Baradlay.

This is just more of code health fixes to change Lengths to references (to avoid copying)
and also use local variable to clean-up code as needed.

* Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::marginWidthForChild):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

Canonical link: https://commits.webkit.org/281343@main

Author: Ahmad Saleem

Source/WebCore/rendering/RenderDeprecatedFlexibleBox.cpp

@@ -1,7 +1,7 @@
 /*
  * Copyright (C) 1999 Lars Knoll ([email protected])
  *           (C) 1999 Antti Koivisto ([email protected])
- * Copyright (C) 2003-2023 Apple Inc. All rights reserved.
+ * Copyright (C) 2003-2024 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
@@ -143,8 +143,8 @@ static LayoutUnit marginWidthForChild(RenderBox* child)
     // A margin basically has three types: fixed, percentage, and auto (variable).
     // Auto and percentage margins simply become 0 when computing min/max width.
     // Fixed margins can be added in as is.
-    Length marginLeft = child->style().marginLeft();
-    Length marginRight = child->style().marginRight();
+    auto& marginLeft = child->style().marginLeft();
+    auto& marginRight = child->style().marginRight();
     LayoutUnit margin;
     if (marginLeft.isFixed())
         margin += marginLeft.value();
@@ -1088,11 +1088,12 @@ LayoutUnit RenderDeprecatedFlexibleBox::allowedChildFlex(RenderBox* child, bool
             // FIXME: For now just handle fixed values.
             LayoutUnit maxWidth = LayoutUnit::max();
             LayoutUnit width = contentWidthForChild(child);
-            if (!child->style().maxWidth().isUndefined() && child->style().maxWidth().isFixed())
-                maxWidth = child->style().maxWidth().value();
-            else if (child->style().maxWidth().type() == LengthType::Intrinsic)
+            auto& maxWidthLength = child->style().maxWidth();
+            if (!maxWidthLength.isUndefined() && maxWidthLength.isFixed())
+                maxWidth = maxWidthLength.value();
+            else if (maxWidthLength.type() == LengthType::Intrinsic)
                 maxWidth = child->maxPreferredLogicalWidth();
-            else if (child->style().maxWidth().isMinIntrinsic())
+            else if (maxWidthLength.isMinIntrinsic())
                 maxWidth = child->minPreferredLogicalWidth();
             if (maxWidth == LayoutUnit::max())
                 return maxWidth;
@@ -1101,8 +1102,9 @@ LayoutUnit RenderDeprecatedFlexibleBox::allowedChildFlex(RenderBox* child, bool
             // FIXME: For now just handle fixed values.
             LayoutUnit maxHeight = LayoutUnit::max();
             LayoutUnit height = contentHeightForChild(child);
-            if (!child->style().maxHeight().isUndefined() && child->style().maxHeight().isFixed())
-                maxHeight = child->style().maxHeight().value();
+            auto& maxHeigthLength = child->style().maxHeight();
+            if (!maxHeigthLength.isUndefined() && maxHeigthLength.isFixed())
+                maxHeight = maxHeigthLength.value();
             if (maxHeight == LayoutUnit::max())
                 return maxHeight;
             return std::max<LayoutUnit>(0, maxHeight - height);
@@ -1113,19 +1115,20 @@ LayoutUnit RenderDeprecatedFlexibleBox::allowedChildFlex(RenderBox* child, bool
     if (isHorizontal()) {
         LayoutUnit minWidth = child->minPreferredLogicalWidth();
         LayoutUnit width = contentWidthForChild(child);
-        if (child->style().minWidth().isFixed())
-            minWidth = child->style().minWidth().value();
-        else if (child->style().minWidth().type() == LengthType::Intrinsic)
+        auto& minWidthLength = child->style().minWidth();
+        if (minWidthLength.isFixed())
+            minWidth = minWidthLength.value();
+        else if (minWidthLength.type() == LengthType::Intrinsic)
             minWidth = child->maxPreferredLogicalWidth();
-        else if (child->style().minWidth().isMinIntrinsic())
+        else if (minWidthLength.isMinIntrinsic())
             minWidth = child->minPreferredLogicalWidth();
-        else if (child->style().minWidth().isAuto())
+        else if (minWidthLength.isAuto())
             minWidth = 0;
 
         LayoutUnit allowedShrinkage = std::min<LayoutUnit>(0, minWidth - width);
         return allowedShrinkage;
     } else {
-        Length minHeight = child->style().minHeight();
+        auto& minHeight = child->style().minHeight();
         if (minHeight.isFixed() || minHeight.isAuto()) {
             LayoutUnit minHeight { child->style().minHeight().value() };
             LayoutUnit height = contentHeightForChild(child);