Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows support #4

Closed
jesus2099 opened this issue Jul 23, 2024 · 4 comments
Closed

Windows support #4

jesus2099 opened this issue Jul 23, 2024 · 4 comments
Labels
invalid This doesn't seem right

Comments

@jesus2099
Copy link

Do you know why this one works on windows: https://github.com/zabe40/musicbrainz-userscripts?tab=readme-ov-file#development
But not this one: ROpdebee/mb-userscripts#779 (comment)
?

@kellnerd
Copy link
Owner

Short answer: ROpdebee's userscripts use their own build process and not the one from this repository 😉

I've also checked again since I was able to build ROpdebee's userscripts on a Windows machine in the past (Windows 10 with either cmd.exe, PowerShell or git bash).
But once I updated my local clone beyond ROpdebee/mb-userscripts@a2e7fc7 (which changes the build process), it is indeed no longer working and I get the same error as you.
I vaguely remember having fixed a similar issue for the old ts-node build process, so there is probably a similar solution for tsx 🤔

@kellnerd
Copy link
Owner

Lol, I just found the commit which I remembered and it helped me to solve the issue.
It is literally the same code change in the same file which is required again 😂
We had reverted it in ROpdebee/mb-userscripts#147 when we switched from ESM to CJS, but now that we are back to ESM it is needed again.

@kellnerd
Copy link
Owner

I created a PR with the fix: ROpdebee/mb-userscripts#780

@jesus2099
Copy link
Author

You rule! 😁👍

@kellnerd kellnerd added the invalid This doesn't seem right label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants