Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make name/card type fields optional #103

Open
swrobel opened this issue Sep 25, 2013 · 2 comments
Open

Make name/card type fields optional #103

swrobel opened this issue Sep 25, 2013 · 2 comments

Comments

@swrobel
Copy link

swrobel commented Sep 25, 2013

We actually take billing name/address on the previous page of our checkout so we don't ask for name on the payment page. I've resorted to creating an input pre-filled with the name they gave on the last page like so:

<input name="cc_name" value="Joe Customer" style="display:none;">

...but I'd rather remove fields if at all possible. I also don't require card type (the processor figures that out) so I don't need to have skeuocard set it. I've had to resort to the following to make skeuocard play nice:

<input name="cc_type" style="display:none;">

Sidenote: skeucard fails spectacularly when it can't find the required fields. I know it's only 1.0, but some console output indicating what went wrong would be nice, rather than the indecipherable error mentioned here: #101
@leek leek mentioned this issue Dec 10, 2013
Open
cvrabie added a commit to cvrabie/skeuocard that referenced this issue Feb 17, 2014
@cvrabie
This is basically a copy of kenkeiter@a40ece6#diff-0 with the compile…
00985a4 
…d changes included.

Since skeuocard basically works only for IE10+ we almost always have to provide a good no-js alternative. In order to style the inputs we will often include them in divs or other containers which will be removed by the initialisation JS. Thanks @leek for the fix.
Refs kenkeiter#103 kenkeiter#101
Fixes kenkeiter#108
cvrabie added a commit to cvrabie/skeuocard that referenced this issue Feb 17, 2014
@cvrabie
Since skeuocard basically works only for IE10+ we almost always have …
24a251f 
…to provide a good no-js alternative. In order to style the inputs we will often include them in divs or other containers which will be removed by the initialisation JS. Thanks @leek for the fix.

This is basically a copy of kenkeiter@a40ece6#diff-0 with the compiled changes included.
Refs kenkeiter#103 kenkeiter#101
Fixes kenkeiter#108

Conflicts:
	javascripts/skeuocard.js
	javascripts/skeuocard.min.js
	javascripts/src/Skeuocard.coffee
cvrabie added a commit to cvrabie/skeuocard that referenced this issue Feb 17, 2014
@cvrabie
Fix input sweep
e4f44ba 
Since skeuocard basically works only for IE10+ we almost always have to provide a good no-js alternative. In order to style the inputs we will often include them in divs or other containers which will be removed by the initialisation JS. Thanks @leek for the fix.
This is basically a copy of kenkeiter@a40ece6#diff-0 with the compiled changes included.
Refs kenkeiter#103 kenkeiter#101
Fixes kenkeiter#108
@cvrabie cvrabie mentioned this issue Feb 17, 2014
Closed
@peterlada
Copy link

I second this. Removing name causes weirdness...

@yazinsai
Copy link

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@swrobel @peterlada @yazinsai