Filter by multiple labels

[smunteankestra]

Feature description

@anna-geller would you approve adding filtering by multiple Labels on flows? (thinking customers might filter by 2-5 or more labels) currently we support just one label
has a brief chat with @aeSouid he said where a re some technical difcutiles with this - he will add some details, if you approve this
if this is not needed please close it

[aeSouid]

@anna-geller @smunteankestra If we want to add the labels with the "IN" or the "NOT IN" operations, we need to carefully design the UI since it is not a standard select input but rather a text input with a specific (key: value) format

[Piyush-r-bhaskar]

@anna-geller @smunteankestra If we want to add the labels with the "IN" or the "NOT IN" operations, we need to carefully design the UI since it is not a standard select input but rather a text input with a specific (key: value) format

Sorry it might be weird but maybe we can remove labels filtering option from KestraFliter and instead allowing users to add the key:value to filter by clicking on labels directly from the tables. this way multiple labels can be added.

[yuri1969]

@Piyush-r-bhaskar IMO users must be able to filter even by label(s) currently not being present on a table.

Table pages are limited to 100 records but hundreds of thousands of records might exist in total. This makes navigating to a particular label to click on nearly impossible.

@smunteankestra Right, filtering by more than a single label is crucial 🙂

E.g. label = "country:Italy" AND label = "type:invoice" AND label = "status:pending"

[anna-geller]

next steps:

• remove the check + background active to make it possible to click another time on the Labels
• follow the GitHub label filter approach

new:

ideally, would be great to show existing label keys:

[MilosPaunovic]

Are we certain that fetching all available labels from executions isn't too costly operation? Maybe @brian-mulier-p could give his opinion on it.

[brian-mulier-p]

As of now I'm not sure we have what's needed to query for distinct label keys, we need to change our way to store it to query them more easily and in a less costly way I think (cc @loicmathieu)

[yuri1969]

Note the possibly high cardinality of existing execution labels. This brings UI/UX implications.

E.g. one of our environments contains 10+ unique label keys each holding tens to hundreds (with a prospect of reaching thousands) of unique values.

[anna-geller]

To clarify: that "ideally" meant more "a nice to have bonus" 😉 totally makes sense to skip that, was a quick comment added during a call

[MilosPaunovic]

As @aeSouid already made some progress on this and shown us in the call this morning, I'll assign the issue to him.

[aeSouid]

merged in develop

labels.mp4

[anna-geller]

remove the check + background active

@aeSouid the comment above made clear that the check and active grey background needs to be removed 😢

[aeSouid]

@anna-geller as discussed yesterday with the frontend team and Nico, we will test it like this on the preview env and then decide whether to remove the check icon and the background.