Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the flow_id and namespace filter not removable in Flow dashboard filter #7316

Open
smunteankestra opened this issue Feb 12, 2025 · 4 comments
Assignees
Labels
area/frontend Needs frontend code changes bug Something isn't working

Comments

@smunteankestra
Copy link
Contributor

smunteankestra commented Feb 12, 2025

Describe the issue

Flows filter should not be present inside Flow

UPDATE: flow_id and namespace filter not removable in Flow dashboard filter

Image

Environment

  • Kestra Version: develop
@smunteankestra smunteankestra added area/backend Needs backend code changes area/frontend Needs frontend code changes bug Something isn't working labels Feb 12, 2025
@smunteankestra smunteankestra self-assigned this Feb 12, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 12, 2025
@MilosPaunovic
Copy link
Member

I think that at some point this was required, so it's not a bug, it's just a product decision do we want to keep it there for clarity (I would recommend) or to remove it, so maybe we can hear from @Ben8t on this?

@Ben8t
Copy link
Member

Ben8t commented Feb 12, 2025

Here is the issue you mentioned #6257.

At first glance it sounds duplicate information with the upper breadcrumb, but it has to be here as it's a dashboard filter. For example adding state=SUCCESS will filter the execution states on the dashboard for this flow.

However it's possible to remove the filter for flow_id and namespace, but it doesn't change the dashboard scope (which is good I think).
Changing the issue to: make the flow_id and namespace filter not removable in flow dashboard filter

@Ben8t Ben8t changed the title Filter inside flows Make the flow_id and namespace filter not removable in Flow dashboard filter Feb 12, 2025
@Ben8t Ben8t removed the area/backend Needs backend code changes label Feb 12, 2025
@MilosPaunovic
Copy link
Member

It is possible to remove those two filters, as we've added them for clarity, because if you're on a http://localhost:5173/ui/flows/edit/company.team/myflow URL, you'll be seeing filtered data by that namespace and flow ID, but as the dashboard looks the same as the main one, maybe it's not that transparent without those filters added.

We also have the issue opened for making labels persistent, if that is what you were aiming for #6256?

@Ben8t
Copy link
Member

Ben8t commented Feb 13, 2025

Yes that's #6256 reasoning. Let's keep this one open as it will be one of the page that need #6256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

4 participants