Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace Files search/filter bar is too large and the Files sidebar should be resizable #7208

Closed
anna-geller opened this issue Feb 5, 2025 · 9 comments · Fixed by #7420
Closed
Assignees
Labels
area/frontend Needs frontend code changes enhancement New feature or request

Comments

@anna-geller
Copy link
Member

Describe the issue

image

https://capture.dropbox.com/b155T7R8xy4918WJ

Environment

  • Kestra Version: develop
@anna-geller anna-geller added bug Something isn't working area/frontend Needs frontend code changes labels Feb 5, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Issues Feb 5, 2025
@MilosPaunovic
Copy link
Member

So, after a bit of investigation, I've came up with this:

  • Editor sidebar should be re-sizable, but the limits are between 20 and 40 percent of the full editor width. (if you can not reproduce resizing altogether, then there is also an underlying problem).
  • If we're showing CombinedEditor, so the editor with docs, topology or blueprints on the right, we have that entire section be limited to 25 to 75 percent in full width, and file tree sidebar takes the percentage of that width.

Not sure if I've explained this good enough, if not, ping me for more details @anna-geller.

So, we'd need to decide here on what we want to do with the width, and would also need a wireframe from @Nico-Kestra for the search bar, on how to limit it's width.

@MilosPaunovic MilosPaunovic moved this from Backlog to In review in Issues Feb 6, 2025
@Nico-Kestra
Copy link
Member

I just think the namespace files explorer is too wide and should be small like on this screen, so I wouldn’t change the width of the search.
Image

@Piyush-r-bhaskar
Copy link
Contributor

Hey @MilosPaunovic & @anna-geller,

You may assign it to me.

@MilosPaunovic
Copy link
Member

I believe this would need some more internal discussion before proceeding, but you can tackle it after, so I'll assign you for now, just don't start the actual work until we decide on the steps.

And the steps need deciding are here #7208 (comment).
So, any thoughts @Ben8t, @anna-geller or @Nico-Kestra?

@Piyush-r-bhaskar
Copy link
Contributor

I believe this would need some more internal discussion before proceeding, but you can tackle it after, so I'll assign you for now, just don't start the actual work until we decide on the steps.

And the steps need deciding are here #7208 (comment).
So, any thoughts @Ben8t, @anna-geller or @Nico-Kestra?

Yeah Sure @MilosPaunovic

@anna-geller
Copy link
Member Author

As discussed via Slack, this must be resizable and the entire sidebar incl filter are too large, let's fix it as far as we can and close

@Ben8t Ben8t removed the bug Something isn't working label Feb 13, 2025
@Piyush-r-bhaskar
Copy link
Contributor

Please do let me know when I should start this.

@anna-geller
Copy link
Member Author

you can go for it 🚀

@MilosPaunovic
Copy link
Member

Thanks for this Piyush! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants