-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Improve the text contrast in the Code Editor in the light mode #3627
Comments
@anna-geller i would like to work on this issue |
Go for it @syedfardeenjeelani! 🚀 |
@MilosPaunovic thank you |
@MilosPaunovic hey i was trying to setup the repo locally but i am facing this issue can you please guide me |
@syedfardeenjeelani Check out this tread on Slack for the way to resolve it.
Let me know if this does it for you. |
@MilosPaunovic thank you i will try it and let you know |
Hi @syedfardeenjeelani, is there any progress on this? |
Hi, I would like to work on the issue |
Absolutely, go for it @PadyA0! 🚀 |
Is there any progress on this @PadyA0? |
Hi I am working on the issue and should update the progress next week. |
@MilosPaunovic Hello, just to confirm, the UI folder has all the code for the code editor part? I was looking at different files to locate the part with the text contrast. |
Yup, everything is definetlly in |
@MilosPaunovic I cannot access the file to the code. Is it possible for me to have the location/name of the file, please? |
How have you tried searching them so far @PadyA0? |
Hey @MilosPaunovic & @anna-geller In case at any point of time it's up for grab. Please assign. & How do you like this contrast ? or let me know if any other palette in mind. |
That looks wonderful @Piyush-r-bhaskar 🤩 I'd love to see a PR from you adding this theme. |
Perfect! Thanks. then 'll raise one by EoD. |
Implementation of this was perfect @Piyush-r-bhaskar, simple, yet, exactly what we were looking for to achieve. Fantastic work! 🚀 |
We got the requirement to use light mode in educational content. For now, the biggest blocker to use it more is that the contrast is not good enough.
I browsed Monaco themes https://github.com/brijeshb42/monaco-themes/, and all have the same light mode with green + blue text with very low contrast.
Context
Compare our UI version:
And the default's IntelliJ GitHub theme (much better contrast due to black + blue text):
The text was updated successfully, but these errors were encountered: